Skip to content

Commit 0fa97b8

Browse files
committed
Add empty process_tags and container_id fields
1 parent a84e055 commit 0fa97b8

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

ext/libdatadog_api/process_discovery.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ static VALUE _native_store_tracer_metadata(int argc, VALUE *argv, VALUE self) {
4949
VALUE service_name = rb_hash_fetch(options, ID2SYM(rb_intern("service_name")));
5050
VALUE service_env = rb_hash_fetch(options, ID2SYM(rb_intern("service_env")));
5151
VALUE service_version = rb_hash_fetch(options, ID2SYM(rb_intern("service_version")));
52+
VALUE process_tags = rb_hash_fetch(options, ID2SYM(rb_intern("process_tags")));
53+
VALUE container_id = rb_hash_fetch(options, ID2SYM(rb_intern("container_id")));
5254

5355
ENFORCE_TYPE(runtime_id, T_STRING);
5456
ENFORCE_TYPE(tracer_language, T_STRING);
@@ -57,6 +59,8 @@ static VALUE _native_store_tracer_metadata(int argc, VALUE *argv, VALUE self) {
5759
ENFORCE_TYPE(service_name, T_STRING);
5860
ENFORCE_TYPE(service_env, T_STRING);
5961
ENFORCE_TYPE(service_version, T_STRING);
62+
ENFORCE_TYPE(process_tags, T_STRING);
63+
ENFORCE_TYPE(container_id, T_STRING);
6064

6165
void* builder = ddog_tracer_metadata_new();
6266

@@ -67,6 +71,8 @@ static VALUE _native_store_tracer_metadata(int argc, VALUE *argv, VALUE self) {
6771
ddog_tracer_metadata_set(builder, DDOG_METADATA_KIND_SERVICE_NAME, StringValueCStr(service_name));
6872
ddog_tracer_metadata_set(builder, DDOG_METADATA_KIND_SERVICE_ENV, StringValueCStr(service_env));
6973
ddog_tracer_metadata_set(builder, DDOG_METADATA_KIND_SERVICE_VERSION, StringValueCStr(service_version));
74+
ddog_tracer_metadata_set(builder, DDOG_METADATA_KIND_PROCESS_TAGS, StringValueCStr(process_tags));
75+
ddog_tracer_metadata_set(builder, DDOG_METADATA_KIND_CONTAINER_ID, StringValueCStr(container_id));
7076

7177
ddog_Result_TracerMemfdHandle result = ddog_tracer_metadata_store(builder);
7278
ddog_tracer_metadata_free(builder);

lib/datadog/core/process_discovery.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ def get_metadata(settings)
4343
hostname: Core::Environment::Socket.hostname,
4444
service_name: settings.service || '',
4545
service_env: settings.env || '',
46-
service_version: settings.version || ''
46+
service_version: settings.version || '',
47+
# TODO: Implement process tags and container id
48+
process_tags: '',
49+
container_id: ''
4750
}
4851
end
4952

sig/datadog/core/process_discovery.rbs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ module Datadog
1313
hostname: String,
1414
service_name: String,
1515
service_env: String,
16-
service_version: String
16+
service_version: String,
17+
process_tags: String,
18+
container_id: String
1719
) -> TracerMemfd?
1820

1921
def self._native_close_tracer_memfd: (TracerMemfd tracer_memfd, Datadog::Core::Logger logger) -> void
@@ -31,7 +33,9 @@ module Datadog
3133
hostname: String,
3234
service_name: String,
3335
service_env: String,
34-
service_version: String
36+
service_version: String,
37+
process_tags: String,
38+
container_id: String
3539
}
3640

3741
def self.apply_at_fork_patch: () -> void

0 commit comments

Comments
 (0)