Apply suggestions

Co-authored-by: Ivo Anjo <[email protected]>

Author: vpellan

lib/datadog/core/utils/time.rb

@@ -10,7 +10,7 @@ module Time
         # Current monotonic time
         #
         # @param unit [Symbol] unit for the resulting value, same as ::Process#clock_gettime, defaults to :float_second
-        # @return [Float] timestamp in the requested unit, since some unspecified starting point
+        # @return [Float|Integer] timestamp in the requested unit, since some unspecified starting point
         def get_time(unit = :float_second)
           Process.clock_gettime(Process::CLOCK_MONOTONIC, unit)
         end

lib/datadog/di/probe_notification_builder.rb

@@ -46,8 +46,6 @@ def build_executed(context)
         build_snapshot(context)
       end
 
-      # Steep: `Integer ** Integer` can also result in Rational (e.g. 10**-2)
-      # which is why it gives an error if NANOSECONDS is set to 10**9.
       NANOSECONDS = 1_000_000_000
       MILLISECONDS = 1000
 

lib/datadog/tracing/span_event.rb

@@ -69,12 +69,8 @@ def to_native_format
 
       private
 
-      # Steep: `Integer ** Integer` can also result in Rational (e.g. 10**-2)
-      # which is why it gives an error if MIN_INT64_SIGNED is set to -2**63.
       MIN_INT64_SIGNED = -2 << 62
-      # DEV: This is incorrect, 2 << 63 - 1 is not the same as 2**63 - 1 (offset by 1).
-      # The correct formula is `(2 << 62) - 1`. Check if it is a breaking change before fixing it.
-      MAX_INT64_SIGNED = 2 << 63 - 1
+      MAX_INT64_SIGNED = (2 << 62) - 1
 
       # Checks the attributes hash to ensure it only contains serializable values.
       # Invalid values are removed from the hash.

lib/datadog/tracing/span_operation.rb

@@ -550,11 +550,10 @@ def duration_marker
       # Used for serialization
       # @return [Integer] in nanoseconds since Epoch
       def start_time_nano
-        # The only place where start_time_nano is called previously checks if span is stopped,
-        # which checks if @end_time is not nil, and the only place where @end_time is set is in stop,
-        # which also sets @start_time if it wasn't already set.
-        # @type ivar @start_time: ::Time
-        @start_time.to_i * 1000000000 + @start_time.nsec
+        return 0 if @start_time.nil?
+
+        # Steep: https://github.com/soutaro/steep/issues/477
+        @start_time.to_i * 1000000000 + @start_time.nsec # steep:ignore NoMethod
       end
 
       # Used for serialization