Fix standardrb complaints

Author: Strech

lib/datadog/open_feature/evaluation_engine.rb

@@ -25,7 +25,7 @@ def initialize(reporter, telemetry:, logger: Datadog.logger)
 
       def fetch_value(flag_key:, expected_type:, evaluation_context: nil)
         unless ALLOWED_TYPES.include?(expected_type)
-          message = "unknown type #{expected_type.inspect}, allowed types #{ALLOWED_TYPES.join(', ')}"
+          message = "unknown type #{expected_type.inspect}, allowed types #{ALLOWED_TYPES.join(", ")}"
 
           return Binding::ResolutionDetails.new(
             error_code: Ext::UNKNOWN_TYPE, error_message: message, reason: Ext::ERROR

lib/datadog/open_feature/exposures/buffer.rb

@@ -7,7 +7,7 @@ module Datadog
   module OpenFeature
     module Exposures
       BufferBaseClass =
-        Core::Environment::Ext::RUBY_ENGINE == 'ruby' ? Core::Buffer::CRuby : Core::Buffer::ThreadSafe
+        (Core::Environment::Ext::RUBY_ENGINE == 'ruby') ? Core::Buffer::CRuby : Core::Buffer::ThreadSafe
 
       class Buffer < BufferBaseClass
         DEFAULT_LIMIT = 1_000

spec/datadog/open_feature/evaluation_engine_spec.rb

@@ -221,8 +221,9 @@
       end
 
       xit 'reconfigures binding evaluator with new flags configuration' do
-        expect { engine.configuration = new_ufc; engine.reconfigure! }
-          .to change { engine.fetch_value(flag_key: 'test', expected_type: :string).value }
+        engine.configuration = new_ufc
+
+        expect { engine.reconfigure! }.to change { engine.fetch_value(flag_key: 'test', expected_type: :string).value }
           .from('hello').to('goodbye')
       end
     end

spec/datadog/open_feature/exposures/batch_builder_spec.rb

@@ -128,5 +128,3 @@
     end
   end
 end
-
-

spec/datadog/open_feature/exposures/deduplicator_spec.rb

@@ -34,7 +34,6 @@
         )
       end
 
-
       it { expect(deduplicator.duplicate?(event)).to be(true) }
     end
 
@@ -162,5 +161,3 @@
     end
   end
 end
-
-

spec/datadog/open_feature/exposures/models/event_spec.rb

@@ -32,7 +32,7 @@
           'active' => true,
           'ratio' => 7.5,
           'nickname' => 'johnny',
-          'ignored_hash' => { foo: 'bar' },
+          'ignored_hash' => {foo: 'bar'},
           'ignored_array' => [1, 2]
         }
       )
@@ -43,7 +43,7 @@
         {
           timestamp: 1_735_689_600_000,
           allocation: {
-             key: '4-for-john-doe'
+            key: '4-for-john-doe'
           },
           flag: {
             key: 'feature_flag'
@@ -104,4 +104,3 @@
     end
   end
 end
-

spec/datadog/open_feature/exposures/reporter_spec.rb

@@ -98,5 +98,3 @@
     end
   end
 end
-
-

spec/datadog/open_feature/exposures/worker_spec.rb

@@ -165,4 +165,3 @@
     end
   end
 end
-

spec/datadog/open_feature/noop_evaluator_spec.rb

@@ -17,4 +17,3 @@
     end
   end
 end
-

spec/datadog/open_feature/provider_spec.rb

@@ -310,9 +310,9 @@
       before { allow(Datadog::OpenFeature).to receive(:engine).and_return(nil) }
 
       it 'returns default value with error details' do
-        result = provider.fetch_object_value(flag_key: 'flag', default_value: { 'default' => true })
+        result = provider.fetch_object_value(flag_key: 'flag', default_value: {'default' => true})
 
-        expect(result.value).to eq({ 'default' => true })
+        expect(result.value).to eq({'default' => true})
         expect(result.error_message).to match(/OpenFeature component must be configured/)
       end
     end
@@ -325,7 +325,7 @@
         provider.init
       end
 
-      let(:result) { provider.fetch_object_value(flag_key: 'flag', default_value: { 'default' => true }) }
+      let(:result) { provider.fetch_object_value(flag_key: 'flag', default_value: {'default' => true}) }
       let(:ufc) do
         <<~JSON
           {