Skip to content

Commit 49e66f9

Browse files
committed
Clarify support for rb_obj_info and why it's OK to not have it
1 parent bec4e41 commit 49e66f9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

ext/datadog_profiling_native_extension/extconf.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ def skip_building_extension!(reason)
141141
# On Ruby 3.5, we can't ask the object_id from IMEMOs (https://github.com/ruby/ruby/pull/13347)
142142
$defs << "-DNO_IMEMO_OBJECT_ID" unless RUBY_VERSION < "3.5"
143143

144-
# This symbol is only visible on certain Ruby versions: 2.6 to 3.2 and 3.4, but not 4.0
144+
# This symbol is exclusively visible on certain Ruby versions: 2.6 to 3.2, as well as 3.4 and 3.5-preview1 (but not 4.0)
145+
# It's only used to get extra information about an object when a failure happens, so it's a "very nice to have" but not
146+
# actually required for correct behavior of the profiler.
145147
$defs << "-DNO_RB_OBJ_INFO" if RUBY_VERSION.start_with?("2.5", "3.3", "4.0")
146148

147149
# On older Rubies, rb_postponed_job_preregister/rb_postponed_job_trigger did not exist

0 commit comments

Comments
 (0)