Commit 662eed8
committed
[PROF-13115] Disable heap profiling on Ruby 4 preview due to incompatibility
**What does this PR do?**
This PR disables the heap profiling feature when running on Ruby 4 as
right now it can trigger the crash reported in
https://bugs.ruby-lang.org/issues/21710 .
**Motivation:**
Until either https://bugs.ruby-lang.org/issues/21710 gets fixed or
we change the heap profiler to use the new
[`rb_gc_mark_weak` API](https://bugs.ruby-lang.org/issues/19783)
it's not safe to enable the heap profiling feature on Ruby 4.
**Additional Notes:**
I'm preparing a PR with other, smaller fixes for the profiler
Ruby 4 support, but I decided to split this one by itself so we
could have a separate, clear, changelog entry about this change,
as well as a single PR to discuss this subject.
**How to test the change?**
We don't yet have Ruby 4 in CI, so this can only be tested locally or
by mocking the `RUBY_VERSION`.1 parent 7084871 commit 662eed8
File tree
3 files changed
+21
-0
lines changed- lib/datadog/profiling
- spec/datadog/profiling
- collectors
3 files changed
+21
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
223 | 229 | | |
224 | 230 | | |
225 | 231 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
868 | 868 | | |
869 | 869 | | |
870 | 870 | | |
| 871 | + | |
871 | 872 | | |
872 | 873 | | |
873 | 874 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
337 | 351 | | |
338 | 352 | | |
339 | 353 | | |
| |||
0 commit comments