wip

Signed-off-by: Marco Costa <[email protected]>

Author: marcotc

ext/datadog_profiling_native_extension/profiling.c

@@ -55,9 +55,7 @@ void DDTRACE_EXPORT Init_datadog_profiling_native_extension(void) {
   rb_define_singleton_method(native_extension_module, "native_working?", native_working_p, 0);
   rb_funcall(native_extension_module, rb_intern("private_class_method"), 1, ID2SYM(rb_intern("native_working?")));
 
-  // Initialize the exception class references
-  // These exception classes should be defined in Ruby code (lib/datadog/profiling.rb)
-  // TODO: Can these classes be defined in Ruby? Will it work outside of GIL?
+  // Exception classes defined in Ruby, in the `Datadog::Profiling` namespace
   eNativeRuntimeError = rb_const_get(profiling_module, rb_intern("NativeRuntimeError"));
   rb_global_variable(&eNativeRuntimeError);
   eNativeArgumentError = rb_const_get(profiling_module, rb_intern("NativeArgumentError"));

ext/datadog_profiling_native_extension/ruby_helpers.c

@@ -12,8 +12,8 @@ static ID _id2ref_id = Qnil;
 static ID inspect_id = Qnil;
 static ID to_s_id = Qnil;
 static ID new_id = 0;
-// Global references to Datadog::Profiling exception classes
-// TODO: Can these classes be defined in Ruby? Will it work outside of GIL?
+
+// Global references to Datadog::Profiling exception classes defined in Ruby.
 VALUE eNativeRuntimeError = Qnil;
 VALUE eNativeArgumentError = Qnil;
 VALUE eNativeTypeError = Qnil;