Add reporting to the evaluation

Author: Strech

lib/datadog/open_feature/evaluation_engine.rb

@@ -36,8 +36,10 @@ def fetch_value(flag_key:, expected_type:, evaluation_context: nil)
         # In the example from the OpenFeature there is zero trust to the result of the evaluation
         # do we want to go that way?
 
-        @evaluator.get_assignment(flag_key, evaluation_context, expected_type, Time.now.utc.to_i)
-        # TODO: insert reporting here
+        result = @evaluator.get_assignment(flag_key, evaluation_context, expected_type, Time.now.utc.to_i)
+        @reporter.report(result, flag_key: flag_key, context: evaluation_context)
+
+        result
       rescue => e
         @telemetry.report(e, description: 'OpenFeature: Failed to fetch value for flag')
 

lib/datadog/open_feature/exposures/reporter.rb

@@ -6,6 +6,7 @@
 module Datadog
   module OpenFeature
     module Exposures
+      # This class is responsible for reporting exposures to the Agent
       class Reporter
         def initialize(worker, telemetry:, logger: Datadog.logger)
           @worker = worker
@@ -16,6 +17,7 @@ def initialize(worker, telemetry:, logger: Datadog.logger)
 
         def report(result, flag_key:, context:)
           return false unless result.do_log
+          return false if context.nil?
 
           event = Models::Event.build(result, flag_key: flag_key, context: context)
           return false if @deduplicator.duplicate?(event)

sig/datadog/open_feature/exposures/reporter.rbs

@@ -2,12 +2,20 @@ module Datadog
   module OpenFeature
     module Exposures
       class Reporter
+        @worker: Worker
+
+        @logger: Core::Logger
+
+        @telemetry: Core::Telemetry::Component
+
+        @deduplicator: Deduplicator
+
         def initialize: (Worker worker, telemetry: Core::Telemetry::Component, ?logger: Core::Logger) -> void
 
         def report: (
           Binding::ResolutionDetails result,
           flag_key: ::String,
-          context: ::OpenFeature::SDK::EvaluationContext
+          context: ::OpenFeature::SDK::EvaluationContext?
         ) -> bool
       end
     end

sig/datadog/open_feature/exposures/worker.rbs

@@ -22,9 +22,9 @@ module Datadog
 
         def stop: (?bool, ?::Integer) -> bool
 
-        def enqueue: (Exposures::Event) -> bool
+        def enqueue: (Exposures::Models::Event event) -> bool
 
-        def dequeue: () -> [::Array[Exposures::Event], ::Integer]
+        def dequeue: () -> [::Array[Exposures::Models::Event], ::Integer]
 
         def flush: () -> void
 
@@ -38,7 +38,7 @@ module Datadog
 
         def perform: (*untyped) -> void
 
-        def send_events: (::Array[Exposures::Event], ::Integer) -> void
+        def send_events: (::Array[Exposures::Models::Event], ::Integer) -> void
 
         def send_payload: (::Hash[::Symbol, untyped]) -> Core::Transport::Response?
       end

spec/datadog/open_feature/exposures/reporter_spec.rb

@@ -87,6 +87,15 @@
         expect(reporter.report(result, flag_key: 'feature_flag', context: context)).to be(false)
       end
     end
+
+    context 'when evaluation context is nil' do
+      it 'skips enqueueing exposure' do
+        expect(deduplicator).not_to receive(:duplicate?)
+        expect(worker).not_to receive(:enqueue)
+
+        expect(reporter.report(result, flag_key: 'feature_flag', context: nil)).to be(false)
+      end
+    end
   end
 end