Enable standard in test suite (#4925)

Author: p-datadog

.rubocop.yml

@@ -22,10 +22,7 @@ AllCops:
     - "spec/**/**/interesting_backtrace_helper.rb" # This file needs quite a few bizarre code patterns by design
     - "vendor/bundle/**/*"
     - "spec/datadog/tracing/contrib/grpc/support/gen/**/*.rb" # Skip protoc autogenerated code
-    - spec/datadog/di/**/*
-    - spec/datadog/core/**/*
-    - spec/datadog/appsec/**/*
-    - spec/rubocop/**/*
+    - spec/**/*
   NewCops: disable # Don't allow new cops to be enabled implicitly.
   SuggestExtensions: false # Stop pushing suggestions constantly.
 

.standard_todo.yml

@@ -27,10 +27,3 @@ ignore:
   - integration/**/**
   - lib-injection/**/**
   - lib/datadog/**/vendor/**/*
-  - spec/*
-  - spec/datadog/*
-  - spec/datadog/core/**/**
-  - spec/datadog/di/integration/*_test_class*.rb
-  - spec/datadog/opentelemetry/**/**
-  - spec/datadog/tracing/**/**
-  - spec/support/**/**

spec/datadog/core/configuration/agent_settings_resolver_spec.rb

@@ -71,7 +71,7 @@
 
   describe 'http adapter hostname' do
     context 'when a custom hostname is specified via the DD_AGENT_HOST environment variable' do
-      let(:environment) { { 'DD_AGENT_HOST' => 'custom-hostname' } }
+      let(:environment) { {'DD_AGENT_HOST' => 'custom-hostname'} }
 
       it 'contacts the agent using the http adapter, using the custom hostname' do
         expect(resolver).to have_attributes(**settings, hostname: 'custom-hostname')
@@ -89,7 +89,7 @@
     end
 
     context 'when a custom hostname is specified via the DD_TRACE_AGENT_URL environment variable' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => "http://custom-hostname:#{port}" } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => "http://custom-hostname:#{port}"} }
 
       it 'contacts the agent using the http adapter, using the custom hostname' do
         expect(resolver).to have_attributes(**settings, hostname: 'custom-hostname')
@@ -312,14 +312,14 @@
     end
 
     context 'when a custom port is specified via the DD_TRACE_AGENT_PORT environment variable' do
-      let(:environment) { { 'DD_TRACE_AGENT_PORT' => '1234' } }
+      let(:environment) { {'DD_TRACE_AGENT_PORT' => '1234'} }
 
       it 'contacts the agent using the http adapter, using the custom port' do
         expect(resolver).to have_attributes(**settings, port: 1234)
       end
 
       context 'when the custom port is invalid' do
-        let(:environment) { { 'DD_TRACE_AGENT_PORT' => 'this-is-an-invalid-port' } }
+        let(:environment) { {'DD_TRACE_AGENT_PORT' => 'this-is-an-invalid-port'} }
 
         before do
           allow(logger).to receive(:warn)
@@ -354,7 +354,7 @@
     end
 
     context 'when a custom port is specified via the DD_TRACE_AGENT_URL environment variable' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => "http://#{hostname}:1234" } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => "http://#{hostname}:1234"} }
 
       it 'contacts the agent using the http adapter, using the custom port' do
         expect(resolver).to have_attributes(**settings, port: 1234)
@@ -476,14 +476,14 @@
     end
 
     context 'when a custom timeout is specified via the DD_TRACE_AGENT_TIMEOUT_SECONDS environment variable' do
-      let(:environment) { { 'DD_TRACE_AGENT_TIMEOUT_SECONDS' => '798' } }
+      let(:environment) { {'DD_TRACE_AGENT_TIMEOUT_SECONDS' => '798'} }
 
       it 'contacts the agent using the http adapter, using the custom timeout' do
         expect(resolver).to have_attributes(**settings, timeout_seconds: 798)
       end
 
       context 'when the custom timeout is invalid' do
-        let(:environment) { { 'DD_TRACE_AGENT_TIMEOUT_SECONDS' => 'this-is-an-invalid-timeout' } }
+        let(:environment) { {'DD_TRACE_AGENT_TIMEOUT_SECONDS' => 'this-is-an-invalid-timeout'} }
 
         before do
           allow(logger).to receive(:warn)
@@ -588,7 +588,7 @@
     end
 
     context 'when DD_TRACE_AGENT_URL is set' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => "#{trace_agent_url_protocol}://custom-hostname:1234" } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => "#{trace_agent_url_protocol}://custom-hostname:1234"} }
 
       context 'when set to https' do
         let(:trace_agent_url_protocol) { 'https' }
@@ -656,7 +656,7 @@
   end
 
   context 'when a custom url is specified via environment variable' do
-    let(:environment) { { 'DD_TRACE_AGENT_URL' => 'http://custom-hostname:1234' } }
+    let(:environment) { {'DD_TRACE_AGENT_URL' => 'http://custom-hostname:1234'} }
 
     it 'contacts the agent using the http adapter, using the custom hostname and port' do
       expect(resolver).to have_attributes(
@@ -668,15 +668,15 @@
     end
 
     context 'when the uri scheme is https' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => 'https://custom-hostname:1234' } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => 'https://custom-hostname:1234'} }
 
       it 'contacts the agent using the http adapter, using ssl: true' do
         expect(resolver).to have_attributes(ssl: true)
       end
     end
 
     context 'when the uri scheme is unix' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => 'unix:///path/to/apm.socket' } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => 'unix:///path/to/apm.socket'} }
       let(:timeout_seconds) { 30 }
 
       it 'contacts the agent via a unix domain socket' do
@@ -691,7 +691,7 @@
     end
 
     context 'when the uri scheme is not http OR https' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => 'steam://custom-hostname:1234' } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => 'steam://custom-hostname:1234'} }
 
       before do
         allow(logger).to receive(:warn)
@@ -726,7 +726,7 @@
     end
 
     context 'when a custom path is specified via the DD_TRACE_AGENT_URL environment variable' do
-      let(:environment) { { 'DD_TRACE_AGENT_URL' => 'unix:///var/uri.socket' } }
+      let(:environment) { {'DD_TRACE_AGENT_URL' => 'unix:///var/uri.socket'} }
 
       it 'contacts the agent using the unix adapter, using the custom path' do
         expect(resolver).to have_attributes(**settings, uds_path: '/var/uri.socket')

spec/datadog/core/configuration/agent_settings_spec.rb

@@ -1,7 +1,6 @@
 require 'datadog/core/configuration/agent_settings'
 
 RSpec.describe Datadog::Core::Configuration::AgentSettings do
-
   describe '#url' do
     context 'when using an unknown adapter' do
       it 'raises an exception' do
@@ -12,4 +11,3 @@
     end
   end
 end
-

spec/datadog/core/configuration/base_spec.rb

@@ -54,7 +54,7 @@
       describe '#initialize' do
         subject(:base_object) { base_class.new(options) }
 
-        let(:options) { { foo: :bar } }
+        let(:options) { {foo: :bar} }
 
         before { allow_any_instance_of(base_class).to receive(:configure) }
 
@@ -68,7 +68,7 @@
         subject(:configure) { base_object.configure(options) }
 
         context 'when given an option' do
-          let(:options) { { foo: :bar } }
+          let(:options) { {foo: :bar} }
 
           context 'that is not defined' do
             it { expect { configure }.to_not raise_error }

spec/datadog/core/configuration/components_spec.rb

@@ -39,7 +39,7 @@
     end
   end
 
-  let(:environment_logger_extra) { { hello: 123, world: '456' } }
+  let(:environment_logger_extra) { {hello: 123, world: '456'} }
 
   include_context 'non-development execution environment'
 
@@ -166,7 +166,7 @@
     context 'given settings' do
       shared_examples_for 'new health metrics' do
         let(:health_metrics) { instance_double(Datadog::Core::Diagnostics::Health::Metrics) }
-        let(:default_options) { { enabled: settings.health_metrics.enabled } }
+        let(:default_options) { {enabled: settings.health_metrics.enabled} }
         let(:options) { {} }
 
         before do
@@ -192,7 +192,7 @@
         end
 
         it_behaves_like 'new health metrics' do
-          let(:options) { { enabled: enabled } }
+          let(:options) { {enabled: enabled} }
         end
       end
 
@@ -206,7 +206,7 @@
         end
 
         it_behaves_like 'new health metrics' do
-          let(:options) { { statsd: statsd } }
+          let(:options) { {statsd: statsd} }
         end
       end
     end
@@ -303,9 +303,9 @@
       shared_examples_for 'new runtime metrics' do
         let(:runtime_metrics) { instance_double(Datadog::Core::Runtime::Metrics) }
         let(:default_options) do
-          { enabled: settings.runtime_metrics.enabled,
-            services: [settings.service],
-            experimental_runtime_id_enabled: settings.runtime_metrics.experimental_runtime_id_enabled, }
+          {enabled: settings.runtime_metrics.enabled,
+           services: [settings.service],
+           experimental_runtime_id_enabled: settings.runtime_metrics.experimental_runtime_id_enabled,}
         end
         let(:options) { {} }
 
@@ -332,7 +332,7 @@
         end
 
         it_behaves_like 'new runtime metrics' do
-          let(:options) { { enabled: enabled } }
+          let(:options) { {enabled: enabled} }
         end
       end
 
@@ -346,7 +346,7 @@
         end
 
         it_behaves_like 'new runtime metrics' do
-          let(:options) { { services: [service] } }
+          let(:options) { {services: [service]} }
         end
       end
 
@@ -360,7 +360,7 @@
         end
 
         it_behaves_like 'new runtime metrics' do
-          let(:options) { { statsd: statsd } }
+          let(:options) { {statsd: statsd} }
         end
       end
 
@@ -374,7 +374,7 @@
         end
 
         it_behaves_like 'new runtime metrics' do
-          let(:options) { { experimental_runtime_id_enabled: experimental_runtime_id_enabled } }
+          let(:options) { {experimental_runtime_id_enabled: experimental_runtime_id_enabled} }
         end
       end
     end
@@ -422,12 +422,12 @@
         end
 
         it_behaves_like 'new runtime metrics worker' do
-          let(:options) { { enabled: enabled } }
+          let(:options) { {enabled: enabled} }
         end
       end
 
       context 'with :opts' do
-        let(:opts) { { custom_option: :custom_value } }
+        let(:opts) { {custom_option: :custom_value} }
 
         before do
           allow(settings.runtime_metrics)
@@ -548,7 +548,7 @@
 
         after { WebMock.disable! }
 
-        let(:info_response) { { endpoints: ['/v0.7/config'] }.to_json }
+        let(:info_response) { {endpoints: ['/v0.7/config']}.to_json }
       end
 
       context 'disabled' do