Skip to content

Commit e44a179

Browse files
committed
Unskip crashtracking, telemetery specs in Github Actions
1 parent 5858773 commit e44a179

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

spec/datadog/core/crashtracking/component_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@
212212
let(:agent_base_url) { "http://#{hostname}:#{port}" }
213213

214214
[:fiddle, :signal].each do |trigger|
215-
it "reports crashes via http when app crashes with #{trigger}", skip: ENV['BATCHED_TASKS'] do
215+
it "reports crashes via http when app crashes with #{trigger}" do
216216
fork_expectations = proc do |status:, stdout:, stderr:|
217217
expect(Signal.signame(status.termsig)).to eq('SEGV').or eq('ABRT')
218218
expect(stderr).to include('[BUG] Segmentation fault')
@@ -269,7 +269,7 @@
269269
# Do nothing, it's ok
270270
end
271271

272-
it 'reports crashes via uds when app crashes with fiddle', skip: ENV['BATCHED_TASKS'] do
272+
it 'reports crashes via uds when app crashes with fiddle' do
273273
fork_expectations = proc do |status:, stdout:, stderr:|
274274
expect(Signal.signame(status.termsig)).to eq('SEGV').or eq('ABRT')
275275
expect(stderr).to include('[BUG] Segmentation fault')

spec/datadog/core/telemetry/component_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
end
120120
end
121121

122-
context 'when in fork', skip: ENV['BATCHED_TASKS'] do
122+
context 'when in fork' do
123123
before { skip 'Fork not supported on current platform' unless Process.respond_to?(:fork) }
124124

125125
it do
@@ -169,7 +169,7 @@
169169
end
170170
end
171171

172-
context 'when in fork', skip: ENV['BATCHED_TASKS'] do
172+
context 'when in fork' do
173173
before { skip 'Fork not supported on current platform' unless Process.respond_to?(:fork) }
174174

175175
it do
@@ -209,7 +209,7 @@
209209
end
210210
end
211211

212-
context 'when in fork', skip: ENV['BATCHED_TASKS'] do
212+
context 'when in fork' do
213213
before { skip 'Fork not supported on current platform' unless Process.respond_to?(:fork) }
214214

215215
it do
@@ -245,7 +245,7 @@
245245
expect(worker).to have_received(:enqueue).with(event)
246246
end
247247

248-
context 'when in fork', skip: !Process.respond_to?(:fork) || ENV['BATCHED_TASKS'] do
248+
context 'when in fork', skip: !Process.respond_to?(:fork) do
249249
it do
250250
telemetry
251251
expect_in_fork do

tasks/github.rake

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
require 'pry'
21
require 'json'
32
require 'psych'
43
require 'ostruct'
@@ -397,16 +396,13 @@ namespace :github do
397396
task :generate_batches do
398397
matrix = eval(File.read('Matrixfile')).freeze # rubocop:disable Security/Eval
399398

400-
exceptions = [
399+
# Uncomment to only runs the specified candidates
400+
candidates = [
401401
# 'sidekiq', # Connection refused - connect(2) for 127.0.0.1:6379 (RedisClient::CannotConnectError)
402+
# 'mongodb', # Connection issue with multi db and process hang
402403
]
403404

404-
# candidates = exceptions
405-
candidates = matrix.keys - exceptions
406-
407-
raise 'No candidates.' if candidates.empty?
408-
409-
matrix = matrix.slice(*candidates)
405+
matrix = matrix.slice(*candidates) unless candidates.empty?
410406

411407
ruby_version = RUBY_VERSION[0..2]
412408

0 commit comments

Comments
 (0)