Skip to content

Commit edd7a25

Browse files
authored
Merge pull request #3877 from DataDog/tonycthsu/backport-disable-persist-credentials
Backport disable persist credentials
2 parents 8b88cdd + abc8342 commit edd7a25

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.github/workflows/lib-injection.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,20 +50,21 @@ jobs:
5050
env:
5151
TEST_LIBRARY: ruby
5252
WEBLOG_VARIANT: ${{ matrix.weblog-variant }}
53-
DOCKER_REGISTRY_IMAGES_PATH: ghcr.io/datadog
54-
DOCKER_IMAGE_TAG: ${{ github.sha }}
53+
LIB_INIT_IMAGE: ghcr.io/datadog/dd-trace-rb/dd-lib-ruby-init:${{ github.sha }}
54+
LIBRARY_INJECTION_TEST_APP_IMAGE: ghcr.io/datadog/system-tests/${{ matrix.weblog-variant }}:latest
5555
BUILDX_PLATFORMS: linux/amd64,linux/arm64/v8
5656
steps:
5757
- name: Checkout system tests
5858
uses: actions/checkout@v4
5959
with:
6060
repository: 'DataDog/system-tests'
61+
persist-credentials: false
6162

6263
- name: Install runner
63-
uses: ./.github/actions/install_runner
64+
uses: ./.github/actions/install_runner
6465

6566
- name: Run K8s Lib Injection Tests
66-
run: ./run.sh K8S_LIB_INJECTION_BASIC
67+
run: ./run.sh K8S_LIBRARY_INJECTION_BASIC
6768

6869
- name: Compress logs
6970
id: compress_logs
@@ -91,6 +92,7 @@ jobs:
9192
uses: actions/checkout@v4
9293
with:
9394
repository: DataDog/system-tests
95+
persist-credentials: false
9496
path: system-tests
9597
- name: Overwrite auto inject script with commit SHA
9698
run: |

.github/workflows/system-tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
uses: actions/checkout@v4
3232
with:
3333
repository: 'DataDog/system-tests'
34+
persist-credentials: false
3435
- name: Pull released image
3536
run: |
3637
if docker pull ${{ env.REPO }}/system-tests/${{ matrix.image.name }}:latest; then
@@ -104,6 +105,7 @@ jobs:
104105
uses: actions/checkout@v4
105106
with:
106107
repository: 'DataDog/system-tests'
108+
persist-credentials: false
107109
- name: Checkout ${{ matrix.library.repository }}
108110
uses: actions/checkout@v4
109111
with:
@@ -250,6 +252,7 @@ jobs:
250252
uses: actions/checkout@v4
251253
with:
252254
repository: 'DataDog/system-tests'
255+
persist-credentials: false
253256
- name: Pull runner image
254257
run: |
255258
docker pull ${{ env.REPO }}/system-tests/runner:gha${{ github.run_id }}-g${{ github.sha }}
@@ -316,6 +319,7 @@ jobs:
316319
uses: actions/checkout@v4
317320
with:
318321
repository: 'DataDog/system-tests'
322+
persist-credentials: false
319323
- name: Retrieve logs
320324
uses: actions/download-artifact@v4
321325
with:

0 commit comments

Comments
 (0)