Add baggage to karafka list of propagation styles (#4614)

Author: vpellan

lib/datadog/tracing/contrib/karafka/distributed/propagation.rb

@@ -31,6 +31,8 @@ def initialize(
                     Tracing::Distributed::Datadog.new(fetcher: Tracing::Distributed::Fetcher),
                   Tracing::Configuration::Ext::Distributed::PROPAGATION_STYLE_TRACE_CONTEXT =>
                     Tracing::Distributed::TraceContext.new(fetcher: Tracing::Distributed::Fetcher),
+                  Tracing::Configuration::Ext::Distributed::PROPAGATION_STYLE_BAGGAGE =>
+                    Tracing::Distributed::Baggage.new(fetcher: Tracing::Distributed::Fetcher),
                   Tracing::Configuration::Ext::Distributed::PROPAGATION_STYLE_NONE => Tracing::Distributed::None.new
                 },
                 propagation_style_inject: propagation_style_inject,

spec/datadog/tracing/contrib/grpc/distributed/propagation_spec.rb

@@ -22,6 +22,22 @@
   let(:propagation_style_extract) { ['datadog', 'tracecontext', 'baggage'] }
   let(:propagation_extract_first) { false }
 
+  it 'contains default inject propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_inject)
+    Datadog.configuration.tracing.propagation_style_inject.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+
+  it 'contains default extract propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_extract)
+    Datadog.configuration.tracing.propagation_style_extract.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+
   it_behaves_like 'Distributed tracing propagator' do
     subject(:propagator) { propagation }
 

spec/datadog/tracing/contrib/http/distributed/propagation_spec.rb

@@ -30,6 +30,22 @@
     WebMock.disable_net_connect!(allow: agent_url)
   end
 
+  it 'contains default inject propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_inject)
+    Datadog.configuration.tracing.propagation_style_inject.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+
+  it 'contains default extract propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_extract)
+    Datadog.configuration.tracing.propagation_style_extract.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+
   it_behaves_like 'Distributed tracing propagator' do
     subject(:propagator) { propagation }
   end

spec/datadog/tracing/contrib/karafka/distributed/propagation_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require 'datadog/tracing/contrib/support/spec_helper'
+
+require 'karafka'
+require 'datadog'
+
+RSpec.describe Datadog::Tracing::Contrib::Karafka::Distributed::Propagation do
+  subject(:propagation) do
+    described_class.new(
+      propagation_style_inject: Datadog.configuration.tracing.propagation_style_inject,
+      propagation_style_extract: Datadog.configuration.tracing.propagation_style_extract,
+      propagation_extract_first: Datadog.configuration.tracing.propagation_extract_first
+    )
+  end
+
+  it 'contains default inject propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_inject)
+    Datadog.configuration.tracing.propagation_style_inject.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+
+  it 'contains default extract propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_extract)
+    Datadog.configuration.tracing.propagation_style_extract.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+end

spec/datadog/tracing/contrib/sidekiq/distributed/propagation_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require 'datadog/tracing/contrib/support/spec_helper'
+
+require 'sidekiq'
+require 'datadog'
+
+RSpec.describe Datadog::Tracing::Contrib::Sidekiq::Distributed::Propagation do
+  subject(:propagation) do
+    described_class.new(
+      propagation_style_inject: Datadog.configuration.tracing.propagation_style_inject,
+      propagation_style_extract: Datadog.configuration.tracing.propagation_style_extract,
+      propagation_extract_first: Datadog.configuration.tracing.propagation_extract_first
+    )
+  end
+
+  it 'contains default inject propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_inject)
+    Datadog.configuration.tracing.propagation_style_inject.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+
+  it 'contains default extract propagation styles in its propagation styles list' do
+    expect(propagation.instance_variable_get(:@propagation_styles).keys)
+      .to include(*Datadog.configuration.tracing.propagation_style_extract)
+    Datadog.configuration.tracing.propagation_style_extract.each do |style|
+      expect(propagation.instance_variable_get(:@propagation_styles)[style]).to_not be_nil
+    end
+  end
+end