Remove logger_without_configuration call in logger_without_components (#4639)

Author: vpellan

lib/datadog/core/configuration.rb

@@ -278,7 +278,6 @@ def replace_components!(settings, old)
       def logger_without_components
         # Use default logger without initializing components.
         # This enables logging during initialization, otherwise we'd run into deadlocks.
-        return logger_without_configuration unless configuration?
 
         @temp_logger ||= begin
           logger = configuration.logger.instance || Core::Logger.new($stdout)
@@ -290,9 +289,14 @@ def logger_without_components
       def logger_without_configuration
         # There's rare cases where we need to use logger during configuration initialization,
         # such as reading stable config. In this case we cannot access configuration.
+
         @temp_config_logger ||= begin
+          debug_env_value = ENV[Ext::Diagnostics::ENV_DEBUG_ENABLED]&.strip&.downcase
+          debug_value = debug_env_value == 'true' || debug_env_value == '1' # rubocop:disable Style/MultipleComparison
+
           logger = Core::Logger.new($stdout)
-          logger.level = ::Logger::DEBUG
+          # We cannot access config and the default level is INFO, so we need to set the level manually
+          logger.level = debug_value ? ::Logger::DEBUG : ::Logger::INFO
           logger
         end
       end

spec/datadog/core/configuration_spec.rb

@@ -407,61 +407,16 @@
       subject(:logger) { test_class.logger }
 
       it { is_expected.to be_a_kind_of(Datadog::Core::Logger) }
+      it { expect(logger.level).to be ::Logger::INFO }
 
-      it 'has the default log level' do
-        # If configuration is not initialized, and components neither, we create a temporary logger with debug level
-        # In order to test that the default log level is INFO, we need to ensure that configuration is initialized.
-        test_class.configuration
-
-        expect(logger.level).to be default_log_level
-      end
-
-      context 'when components are not initialized but configuration is' do
-        before do
-          test_class.configuration
-        end
-
-        it 'calls logger_without_components' do
-          expect(test_class).to receive(:logger_without_components)
-
-          logger
-        end
-
-        it 'does not call logger_without_configuration' do
-          expect(test_class).to_not receive(:logger_without_configuration)
-
-          logger
-        end
-
+      context 'when components are not initialized' do
         it 'does not cause them to be initialized' do
           logger
 
           expect(test_class.send(:components?)).to be false
         end
       end
 
-      context 'when configuration is not initialized' do
-        it { expect(logger.level).to be ::Logger::DEBUG }
-
-        it 'calls logger_without_configuration' do
-          expect(test_class).to receive(:logger_without_configuration)
-
-          logger
-        end
-
-        it 'does not call configuration' do
-          expect(test_class).to_not receive(:configuration)
-
-          logger
-        end
-
-        it 'returns a logger without configuration' do
-          logger
-
-          expect(logger).to be_a_kind_of(Datadog::Core::Logger)
-        end
-      end
-
       context 'when components are being replaced' do
         before do
           test_class.configure {}
@@ -485,6 +440,23 @@
       end
     end
 
+    describe '#logger_without_configuration' do
+      subject(:logger_without_configuration) { test_class.send(:logger_without_configuration) }
+      context 'when configuration is not initialized and DD_TRACE_DEBUG is not set' do
+        it { expect(logger_without_configuration.level).to be ::Logger::INFO }
+      end
+
+      context 'when configuration is not initialized and DD_TRACE_DEBUG is set' do
+        around do |example|
+          ClimateControl.modify('DD_TRACE_DEBUG' => 'true') do
+            example.run
+          end
+        end
+
+        it { expect(logger_without_configuration.level).to be ::Logger::DEBUG }
+      end
+    end
+
     describe '#runtime_metrics' do
       subject(:runtime_metrics) { test_class.send(:components).runtime_metrics }