Skip to content

Add comment for skipped mongodb spec #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Add comment for skipped mongodb spec #4369

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96b3c0f
Remove skipped mongodb spec.
sarahchen6 Feb 11, 2025
44a35bf
Change localhost to host.docker.internal.
sarahchen6 Feb 13, 2025
04d8dd1
Revert previous changes.
sarahchen6 Feb 13, 2025
1846eed
Add comment why we're still skipping the spec.
sarahchen6 Feb 13, 2025
c23f7da
Test linking for 3.4.
sarahchen6 Feb 13, 2025
6c37ca0
Revert previous change.
sarahchen6 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions spec/datadog/tracing/contrib/mongodb/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@
end
end

# Our GHA Unit Tests run in docker containers, where "localhost" refers to the container itself.
# As a result, the secondary client (with host "localhost") cannot connect to the primary MongoDB
# service, causing the test to timeout while waiting for "primary server [to be] available in cluster".
# One solution is to pull a second MongoDB service and set the secondary client accordingly. However,
# given the large amount of services already being pulled, this spec remains skipped on GHA for now.
context 'secondary client', skip: ENV['BATCHED_TASKS'] do
around do |example|
without_warnings do
Expand Down
Loading