Uncomment skips for sidekiq, crashtracking, and telemetry specs. #4374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm going to split this up into separate PRs so that I can test the specs individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Un-skip specs for sidekiq, crashtracking, and telemetry.
Motivation:
These specs are known flaky. Let's see what happens when we re-enable them!
We want to enable all tests for our migration to GHA: https://github.com/DataDog/ruby-guild/issues/214.
Change log entry
None.
Additional Notes:
How to test the change?
Consistently green GHA Unit Tests. I'll test this by running GHA Unit Tests multiple times.