Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 13, 2025

What does this PR do?

  1. Use the docker image instead of install the binaries
  2. Clear git metadata by avoid checking out of the repo
  3. Manually provide git metadata with the commit sha for the pull request event

Change log entry
None

@github-actions
Copy link

github-actions bot commented Feb 13, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-13 16:54:00 UTC

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 17:14:21

Comparing candidate commit 8735238 in PR branch tonycthsu/gha-codeowners with baseline commit 44bbcc1 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-3040.861op/s; -2959.009op/s] or [-9.189%; -8.942%]

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/gha-codeowners branch from be0d776 to 3a1640b Compare February 13, 2025 16:41
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/gha-codeowners branch from 3a1640b to 8735238 Compare February 13, 2025 16:51
@TonyCTHsu TonyCTHsu added the dev/github Github repository maintenance and automation label Feb 13, 2025
@DataDog DataDog deleted a comment from datadog-datadog-prod-us1 bot Feb 13, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (44bbcc1) to head (8735238).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4382   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files        1351     1351           
  Lines       82697    82697           
  Branches     4198     4198           
=======================================
  Hits        80764    80764           
  Misses       1933     1933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 13, 2025 17:17
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 13, 2025 17:17
@TonyCTHsu TonyCTHsu merged commit 7f7a32d into master Feb 13, 2025
497 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/gha-codeowners branch February 13, 2025 18:28
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/github Github repository maintenance and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants