Skip to content

Conversation

@TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 19, 2025

What does this PR do?

  1. Extract mongo to its own groups (latest and min)
  2. Fix invalid configuration for version >= 2.15.0 with auth_source
  3. Fix brittle assertion with regex.

PS: The min group is skipped for now, due to JSON formatting issue, to be addressed by: #4403

Change log entry
Nope

@github-actions
Copy link

github-actions bot commented Feb 19, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-19 15:42:32 UTC

@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2025

Benchmarks

Benchmark execution time: 2025-02-19 18:55:03

Comparing candidate commit 26a11dc in PR branch tonycthsu/extract-mongo with baseline commit 30f6e21 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 19, 2025 15:41
@TonyCTHsu TonyCTHsu requested review from a team as code owners February 19, 2025 15:41
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Feb 19, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 19, 2025

Datadog Report

Branch report: tonycthsu/extract-mongo
Commit report: 26a11dc
Test service: dd-trace-rb

✅ 0 Failed, 20606 Passed, 1372 Skipped, 3m 7.51s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (6fa4413) to head (ab4ece4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4410   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files        1366     1366           
  Lines       83397    83402    +5     
  Branches     4231     4231           
=======================================
+ Hits        81491    81498    +7     
+ Misses       1906     1904    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y9v y9v enabled auto-merge February 19, 2025 16:59
@y9v y9v merged commit f710dac into master Feb 19, 2025
506 checks passed
@y9v y9v deleted the tonycthsu/extract-mongo branch February 19, 2025 19:52
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec) tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants