Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented Mar 12, 2025

What does this PR do?

Moves the "endpoint not supported" and "endpoint not defined" exceptions into the core.

Motivation:
Currently these exceptions are defined for each endpoint but their contents is identical.

Change log entry
None

Additional Notes:

How to test the change?
Existing unit tests

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-03-12 14:14:55 UTC

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Mar 12, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 12, 2025

Datadog Report

Branch report: transport-dry-4
Commit report: 8447a7c
Test service: dd-trace-rb

✅ 0 Failed, 20438 Passed, 1369 Skipped, 3m 12.67s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025

Benchmarks

Benchmark execution time: 2025-03-18 19:20:50

Comparing candidate commit 8447a7c in PR branch transport-dry-4 with baseline commit 7d88b81 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (7d88b81) to head (8447a7c).
Report is 693 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/core/remote/transport/http/config.rb 66.66% 1 Missing ⚠️
.../datadog/core/remote/transport/http/negotiation.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4484      +/-   ##
==========================================
+ Coverage   97.70%   97.72%   +0.02%     
==========================================
  Files        1381     1383       +2     
  Lines       83973    83939      -34     
  Branches     4251     4254       +3     
==========================================
- Hits        82043    82027      -16     
+ Misses       1930     1912      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog marked this pull request as ready for review March 12, 2025 14:14
@p-datadog p-datadog requested review from a team as code owners March 12, 2025 14:14
@p-datadog p-datadog changed the title DRY transport exceptions DEBUG-3568 DRY transport exceptions Mar 17, 2025
@p-datadog p-datadog requested a review from Strech March 18, 2025 18:19
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Cool

P.S I have a feeling that we might want to mark second argument with name, but it's not a blocker

@p-datadog
Copy link
Member Author

I am currently focusing on removing duplication from the transport code and making it more streamlined but if you have specific requests/suggestions I can probably sneak them in.

@p-datadog p-datadog merged commit b27ad8d into master Mar 19, 2025
461 checks passed
@p-datadog p-datadog deleted the transport-dry-4 branch March 19, 2025 14:41
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants