-
Notifications
You must be signed in to change notification settings - Fork 398
DEBUG-3568 DRY transport exceptions #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-03-12 14:14:55 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20438 Passed, 1369 Skipped, 3m 12.67s Total Time |
3b6eb54 to
b2120ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4484 +/- ##
==========================================
+ Coverage 97.70% 97.72% +0.02%
==========================================
Files 1381 1383 +2
Lines 83973 83939 -34
Branches 4251 4254 +3
==========================================
- Hits 82043 82027 -16
+ Misses 1930 1912 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Cool
P.S I have a feeling that we might want to mark second argument with name, but it's not a blocker
|
I am currently focusing on removing duplication from the transport code and making it more streamlined but if you have specific requests/suggestions I can probably sneak them in. |
What does this PR do?
Moves the "endpoint not supported" and "endpoint not defined" exceptions into the core.
Motivation:
Currently these exceptions are defined for each endpoint but their contents is identical.
Change log entry
None
Additional Notes:
How to test the change?
Existing unit tests