Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Mar 25, 2025

What does this PR do?
It updates libddwaf gem dependency to 1.21.0.0.1

Motivation:
We have to update libddwaf to enable system tests for SQLi and SSRF features.

Change log entry
None. This is internal change.

Additional Notes:
None.

How to test the change?
CI and manual testing

@y9v y9v self-assigned this Mar 25, 2025
@y9v y9v requested a review from a team as a code owner March 25, 2025 17:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (ef85993) to head (f55aafb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4537      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1392     1392              
  Lines       84890    84890              
  Branches     4277     4277              
==========================================
- Hits        82989    82988       -1     
- Misses       1901     1902       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 25, 2025

Datadog Report

Branch report: appsec-update-libddwaf-to-1-21
Commit report: f55aafb
Test service: dd-trace-rb

✅ 0 Failed, 20779 Passed, 1374 Skipped, 3m 12.52s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 25, 2025

Benchmarks

Benchmark execution time: 2025-03-26 12:02:59

Comparing candidate commit f55aafb in PR branch appsec-update-libddwaf-to-1-21 with baseline commit ef85993 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-2723.013op/s; -2656.781op/s] or [-8.636%; -8.426%]

@y9v y9v force-pushed the appsec-update-libddwaf-to-1-21 branch from f1abb97 to 44c1f87 Compare March 26, 2025 11:29
@Strech
Copy link
Member

Strech commented Mar 26, 2025

@y9v are you sure that we don't need any mention in the change logs? I think there is some new detectors, or we don't make use of them?

@y9v
Copy link
Member Author

y9v commented Mar 26, 2025

@Strech We are not using any of the new shi_detector and lfi_detector detectors yet. The rest of the changes to libddwaf seem to be internal or related to rules, so I think we can omit the changelog entry here

@y9v y9v merged commit 18a0a6d into master Mar 26, 2025
472 checks passed
@y9v y9v deleted the appsec-update-libddwaf-to-1-21 branch March 26, 2025 14:51
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants