Skip to content

Conversation

@p-datadog
Copy link
Member

What does this PR do?

Makes type checking pass on master by adding format_trace_id_128 to types

Motivation:

Red CI on master

Change log entry
None: I added the change log entry to #4499 which would also cover the changes in this PR

Additional Notes:

The issue was the combination of #4499 and #4528 - the first PR enabled type checking of correlation.rb and the second one added a method but not a type signature when type checking ignored the file.

How to test the change?
Existing CI

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (e239a85) to head (b91e0ad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1392     1392              
  Lines       84981    84980       -1     
  Branches     4287     4287              
==========================================
- Hits        83092    83087       -5     
- Misses       1889     1893       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: fix-type-check
Commit report: b91e0ad
Test service: dd-trace-rb

✅ 0 Failed, 20786 Passed, 1373 Skipped, 3m 14.29s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 30, 2025

Benchmarks

Benchmark execution time: 2025-03-30 06:23:56

Comparing candidate commit b91e0ad in PR branch fix-type-check with baseline commit e239a85 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - hold / resume

  • 🟩 throughput [+122998.249op/s; +124461.676op/s] or [+7.789%; +7.881%]

@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Mar 31, 2025
@TonyCTHsu TonyCTHsu merged commit b539362 into master Mar 31, 2025
255 checks passed
@TonyCTHsu TonyCTHsu deleted the fix-type-check branch March 31, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/internal Other internal work that does not need to be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants