Skip to content

Conversation

@p-datadog
Copy link
Member

What does this PR do?

Repairs the warning generated with ruby -w:

/home/w/apps/dd-trace-rb/lib/datadog/profiling.rb:81: warning: method redefined; discarding old allocation_count
/home/w/apps/dd-trace-rb/lib/datadog/profiling.rb:57: warning: previous definition of allocation_count was here

Motivation:

Warning-clean library

Change log entry
Yes: repair ruby -w warning in profiler

Additional Notes:
PRs fixing warnings in other components: #4547, #4548

How to test the change?
Tested manually with:

irb -Ilib -rdatadog/profiliing

@p-datadog p-datadog requested review from a team as code owners March 31, 2025 09:43
@p-datadog p-datadog requested a review from ivoanjo March 31, 2025 09:44
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I had missed this new warning! Thank you for the fix.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (e239a85) to head (d9d6e4a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4549      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.02%     
==========================================
  Files        1392     1392              
  Lines       84981    84982       +1     
  Branches     4287     4287              
==========================================
- Hits        83093    83079      -14     
- Misses       1888     1903      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 31, 2025

Datadog Report

Branch report: fix-method-override-warning-in-profiler
Commit report: d9d6e4a
Test service: dd-trace-rb

✅ 0 Failed, 20785 Passed, 1374 Skipped, 3m 15.92s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-03-31 11:14:34

Comparing candidate commit d9d6e4a in PR branch fix-method-override-warning-in-profiler with baseline commit b539362 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-3028.062op/s; -2951.943op/s] or [-9.371%; -9.135%]

@p-datadog p-datadog merged commit 1f877ff into master Mar 31, 2025
442 checks passed
@p-datadog p-datadog deleted the fix-method-override-warning-in-profiler branch March 31, 2025 11:34
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 31, 2025
@vpellan vpellan mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants