Skip to content

Conversation

@p-datadog
Copy link
Member

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions
Copy link

github-actions bot commented May 8, 2025

👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-05-08 17:57:08 UTC

@github-actions github-actions bot added the core Involves Datadog core libraries label May 8, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 8, 2025

Datadog Report

Branch report: components
Commit report: 21fc8da
Test service: dd-trace-rb

✅ 0 Failed, 21219 Passed, 1376 Skipped, 3m 42.06s Total Time
❄️ 3 New Flaky

New Flaky Tests (3)

  • Rack testing for http.route sets http.route tag on request to base route - rspec - Last Failure

    Expand for error
     Please invoke Datadog.configure at least once before calling this method
     
     Failure/Error: raise 'Please invoke Datadog.configure at least once before calling this method' unless @propagation
     
     RuntimeError:
       Please invoke Datadog.configure at least once before calling this method
     ./lib/datadog/tracing/contrib/http.rb:26:in \`extract'
     ./lib/datadog/tracing/contrib/rack/middlewares.rb:45:in \`call'
     /usr/local/bundle/gems/rack-test-2.1.0/lib/rack/test.rb:360:in \`process_request'
     /usr/local/bundle/gems/rack-test-2.1.0/lib/rack/test.rb:163:in \`custom_request'
     ...
    
  • Rack testing for http.route sets http.route tag on request to nested app route - rspec - Last Failure

    Expand for error
     Please invoke Datadog.configure at least once before calling this method
     
     Failure/Error: raise 'Please invoke Datadog.configure at least once before calling this method' unless @propagation
     
     RuntimeError:
       Please invoke Datadog.configure at least once before calling this method
     ./lib/datadog/tracing/contrib/http.rb:26:in \`extract'
     ./lib/datadog/tracing/contrib/rack/middlewares.rb:45:in \`call'
     /usr/local/bundle/gems/rack-test-2.1.0/lib/rack/test.rb:360:in \`process_request'
     /usr/local/bundle/gems/rack-test-2.1.0/lib/rack/test.rb:163:in \`custom_request'
     ...
    
  • Rack testing for http.route sets no http.route tag when response status is 404 - rspec - Last Failure

    Expand for error
     Please invoke Datadog.configure at least once before calling this method
     
     Failure/Error: raise 'Please invoke Datadog.configure at least once before calling this method' unless @propagation
     
     RuntimeError:
       Please invoke Datadog.configure at least once before calling this method
     ./lib/datadog/tracing/contrib/http.rb:26:in 'Datadog::Tracing::Contrib::HTTP.extract'
     ./lib/datadog/tracing/contrib/rack/middlewares.rb:45:in 'Datadog::Tracing::Contrib::Rack::TraceMiddleware#call'
     /usr/local/bundle/gems/rack-test-2.1.0/lib/rack/test.rb:360:in 'Rack::Test::Session#process_request'
     /usr/local/bundle/gems/rack-test-2.1.0/lib/rack/test.rb:163:in 'Rack::Test::Session#custom_request'
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented May 8, 2025

Benchmarks

Benchmark execution time: 2025-05-09 15:30:44

Comparing candidate commit 21fc8da in PR branch components with baseline commit e68b92a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@p-datadog p-datadog closed this May 12, 2025
@p-datadog p-datadog deleted the components branch May 12, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants