Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented May 13, 2025

What does this PR do?
Adds the enabled status of dynamic instrumentation to telemetry app-started event

Motivation:
Reporting of DI status is required for DI UI to work correctly as well as for internal DI monitoring/troubleshooting tools

Change log entry
None

Additional Notes:

To make DI always reportable via telemetry I had to make its configuration defined on all Ruby runtimes including the ones where the product itself does not work (Ruby 2.5, JRuby). Additional loading test was added to verify ability to set DI configuration options on all runtimes; this test mirrors failures I've gotten on rails42 and rails50 system test configurations which use Ruby 2.5 once I started sending DI status to telemetry.

How to test the change?
Unit tests + system tests enabled in DataDog/system-tests#4656

@github-actions
Copy link

github-actions bot commented May 13, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-05-14 14:36:39 UTC

@github-actions github-actions bot added the core Involves Datadog core libraries label May 13, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Report

Branch report: telemetry-di
Commit report: 747a986
Test service: dd-trace-rb

✅ 0 Failed, 21241 Passed, 1374 Skipped, 3m 50.36s Total Time

@p-datadog p-datadog changed the title Report state of dynamic instrumentation to telemetry DEBUG-3573 Report state of dynamic instrumentation to telemetry May 14, 2025
@p-datadog p-datadog marked this pull request as ready for review May 14, 2025 14:35
@p-datadog p-datadog requested a review from a team as a code owner May 14, 2025 14:35
@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025

Benchmarks

Benchmark execution time: 2025-05-15 00:16:20

Comparing candidate commit 747a986 in PR branch telemetry-di with baseline commit 1764000 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (1764000) to head (747a986).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/di/boot.rb 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4647   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1419     1422    +3     
  Lines       86623    86675   +52     
  Branches     4397     4403    +6     
=======================================
+ Hits        84693    84746   +53     
+ Misses       1930     1929    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@p-datadog p-datadog added this to the 2.16.0 milestone May 14, 2025
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 much clearer

@p-datadog p-datadog merged commit 3eb5760 into master May 15, 2025
444 checks passed
@p-datadog p-datadog deleted the telemetry-di branch May 15, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants