-
Notifications
You must be signed in to change notification settings - Fork 399
DEBUG-3573 Report state of dynamic instrumentation to telemetry #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-05-14 14:36:39 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 21241 Passed, 1374 Skipped, 3m 50.36s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4647 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1419 1422 +3
Lines 86623 86675 +52
Branches 4397 4403 +6
=======================================
+ Hits 84693 84746 +53
+ Misses 1930 1929 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 much clearer
What does this PR do?
Adds the enabled status of dynamic instrumentation to telemetry app-started event
Motivation:
Reporting of DI status is required for DI UI to work correctly as well as for internal DI monitoring/troubleshooting tools
Change log entry
None
Additional Notes:
To make DI always reportable via telemetry I had to make its configuration defined on all Ruby runtimes including the ones where the product itself does not work (Ruby 2.5, JRuby). Additional loading test was added to verify ability to set DI configuration options on all runtimes; this test mirrors failures I've gotten on rails42 and rails50 system test configurations which use Ruby 2.5 once I started sending DI status to telemetry.
How to test the change?
Unit tests + system tests enabled in DataDog/system-tests#4656