Fix JRuby 9.4 RSpec termination race-condition #4955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpellan
approved these changes
Oct 7, 2025
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 99076bd | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-10-07 16:13:02 Comparing candidate commit 99076bd in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:profiling - intern_all 1000 repeated strings
|
p-datadog
reviewed
Oct 7, 2025
| # it is not preventing a race condition. But in some rare cases | ||
| # in RSpec of JRuby 9.4 the test case will not let locking happen. | ||
| # That will cause specs to fail. | ||
| @mutex.unlock if @mutex.locked? |
Member
There was a problem hiding this comment.
This does really not look right to me at all...
Member
Author
|
Closing in favor of long-term solution #4957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix intermittent bug in RSpec test case for JRuby 9.4 (TESTS ONLY)
Motivation:
The test is suboptimal and will hammer the lifting method which will cause the remote worker thread to continue lifting when RSpec is already finished the test case.
That will lead to exception that Mutex is not locked. And boiled down as Deadlocks and Havoc
Change log entry
None.
Additional Notes:
The test should be improved because the worker thread consider itself unhealthy.
How to test the change?
CI