[NO-TICKET] Extract all .rb files from folders in Steepfile #5004
+422
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 57b40ab | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-10-28 19:12:44 Comparing candidate commit 57b40ab in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
ivoanjo
approved these changes
Oct 29, 2025
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
👍 I like it! Also it makes our Steepfile look worse which gives us a motivator to continue improving this ;)
Strech
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR details all the currently existing ignored .rb files in the Steepfile instead of specifying folders
Motivation:
This will ensure that new files added in these folders later are NOT ignored unless explicitly added to the list (and hopefully enforce typing on them)
Change log entry
None.
Additional Notes:
Newly added methods to ignored files will still be ignored. A way to fix that would actually be to remove any ignored file (but this would drop the status of typing to ~18%)
How to test the change?