[NO-TICKET] Refresh libdatadog dev docs + remove accidental dependency on profiling.h #5018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files don't actually need to pull in `profiling.h`. Doing this was actually a leftover of when we extracted this file from the profiling native gem, and in practice the only useful thing `profiling.h` was doing was pull in `common.h`.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: eb3b905 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-11-03 09:54:06 Comparing candidate commit eb3b905 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:profiling - Allocations (baseline)
|
p-datadog
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR groups two small changes:
datadog_ruby_common.hon profilingMotivation:
Both of the things fixed/improved here came up during review of #5007 .
Change log entry
None.
Additional Notes:
N/A
How to test the change?
The
datadog_ruby_common.hchange is covered by our CI: If we broke the native extensions, many specs would start failing.