Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented Nov 3, 2025

What does this PR do?

Adds support for taking lengths of hashes in dynamic instrumentation expression language.

Motivation:
Feature parity / we have a system test checking for this functionality.

Change log entry
Yes: dynamic instrumentation: support length operation on hashes in expression language

Additional Notes:

This PR also adds additional test cases that are tested by system tests to detect failures in the respective code earlier and have test coverage for them in dd-trace-rb (@value usage when iterating hashes, length of arrays).

How to test the change?
Unit tests added

@github-actions github-actions bot added the core Involves Datadog core libraries label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-11-03 13:05:21 UTC

@datadog-official
Copy link

datadog-official bot commented Nov 3, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.55% (+0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7979323 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 3, 2025

Benchmarks

Benchmark execution time: 2025-11-03 15:14:05

Comparing candidate commit 7979323 in PR branch di-hash-length with baseline commit 05283ad in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@p-datadog p-datadog marked this pull request as ready for review November 3, 2025 13:05
@p-datadog p-datadog requested a review from a team as a code owner November 3, 2025 13:05
@p-datadog p-datadog merged commit 8c1e731 into master Nov 3, 2025
557 checks passed
@p-datadog p-datadog deleted the di-hash-length branch November 3, 2025 15:41
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants