Skip to content

Conversation

@p-datadog
Copy link
Member

@p-datadog p-datadog commented Nov 7, 2025

What does this PR do?

  1. closes DSM Processor after the test to avoid leaking background threads created by the processor
  2. adds an exclusion for FFI threads to the thread leak detector
  3. removes existing exclusion of detector in a test that triggered FFI threads

Motivation:
Fix https://github.com/DataDog/ruby-guild/issues/274

Change log entry
None

Additional Notes:

How to test the change?

Ran changed files locally to verify no output from thread leak detector

@p-datadog p-datadog requested review from a team as code owners November 7, 2025 22:32
@p-datadog p-datadog requested a review from mabdinur November 7, 2025 22:32
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Nov 7, 2025
@p-datadog p-datadog requested a review from ericfirth November 7, 2025 22:33
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 7, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.55% (+0.13%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ccf0692 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025

Benchmarks

Benchmark execution time: 2025-11-12 14:50:30

Comparing candidate commit ccf0692 in PR branch dsm-thread-leak with baseline commit bfe50a4 in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+9734.307op/s; +10191.881op/s] or [+6.824%; +7.145%]

scenario:line instrumentation - untargeted

  • 🟩 throughput [+4948.530op/s; +5064.572op/s] or [+9.200%; +9.416%]

scenario:method instrumentation

  • 🟩 throughput [+11941.885op/s; +12492.566op/s] or [+7.268%; +7.603%]

scenario:profiling - Allocations (baseline)

  • 🟥 throughput [-315046.008op/s; -300903.759op/s] or [-5.949%; -5.682%]

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Left a few notes, but overall it LGTM. Thanks for making this better!

@p-datadog p-datadog merged commit 23debfe into master Nov 18, 2025
276 checks passed
@p-datadog p-datadog deleted the dsm-thread-leak branch November 18, 2025 17:11
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants