-
Notifications
You must be signed in to change notification settings - Fork 399
Fix thread leak in DSM specs, clean up FFI thread leak checks #5032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: ccf0692 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-11-12 14:50:30 Comparing candidate commit ccf0692 in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:line instrumentation - untargeted
scenario:method instrumentation
scenario:profiling - Allocations (baseline)
|
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Left a few notes, but overall it LGTM. Thanks for making this better!
Co-authored-by: Ivo Anjo <[email protected]>
What does this PR do?
Motivation:
Fix https://github.com/DataDog/ruby-guild/issues/274
Change log entry
None
Additional Notes:
How to test the change?
Ran changed files locally to verify no output from thread leak detector