Trivial changes to GH actions (#265)

* Remove cppcheck GH job

* Improve build and reports artifact naming for better GitHub UI sorting

Change artifact names to lead with category in brackets for better organization:
- 'test-platform (java, config) (reports)' → '[reports] test-platform (java, config)'
- 'test-platform (java, config) (build)' → '[build] test-platform (java, config)'

Leave failures artifacts unchanged as they may be used downstream.
This groups build and reports artifacts by type in the GitHub UI.

* Update IBM Java 8 URL

Author: jbachorik

.github/workflows/cache_java.yml

@@ -34,7 +34,7 @@ env:
   # jdk1.8.0_361
   JAVA_8_ORACLE_URL: "https://javadl.oracle.com/webapps/download/AutoDL?BundleId=247926_0ae14417abb444ebb02b9815e2103550"
 
-  JAVA_8_IBM_URL: "https://public.dhe.ibm.com/ibmdl/export/pub/systems/cloud/runtimes/java/8.0.8.40/linux/x86_64/ibm-java-jre-8.0-8.40-linux-x86_64.tgz"
+  JAVA_8_IBM_URL: "https://public.dhe.ibm.com/ibmdl/export/pub/systems/cloud/runtimes/java/8.0.8.50/linux/x86_64/ibm-java-jre-8.0-8.50-linux-x86_64.tgz"
 
   JAVA_8_ZING_URL         : "https://cdn.azul.com/zing-zvm/ZVM23.05.0.0/zing23.05.0.0-2-jdk8.0.372-linux_x64.tar.gz"
   JAVA_8_ZING_AARCH64_URL : "https://cdn.azul.com/zing-zvm/ZVM24.10.0.0/zing24.10.0.0-4-jdk8.0.431-linux_aarch64.tar.gz"

.github/workflows/codecheck.yml

@@ -53,47 +53,6 @@ jobs:
         with:
           body-file: comment.html
 
-  cppcheck:
-    if: needs.check-for-pr.outputs.skip != 'true'
-    runs-on: ubuntu-latest
-    env:
-      HEAD_REF: ${{ github.head_ref }}
-    steps:
-      - uses: actions/checkout@v3
-      - name: System setup
-        run: |
-          sudo apt-get update
-          sudo apt install -y cppcheck xsltproc
-      - name: Set up Python
-        uses: actions/setup-python@v2
-        with:
-          python-version: 3.9
-      - name: Install Python dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install beautifulsoup4
-      - name: Run Cppcheck
-        id: run-cppcheck
-        run: |
-          cppcheck --quiet --force --enable=all --std=c++17 --language=c++ --inline-suppr --suppressions-list=.github/scripts/cppcheck-suppressions.txt --xml --output-file=report.xml ddprof-lib/src/main/cpp/*
-          xsltproc --output report.html .github/scripts/cppcheck-html.xslt report.xml
-          xsltproc --output report-gh.html .github/scripts/cppcheck-gh.xslt report.xml
-          sed -i "s#target_branch#${HEAD_REF}#g" report.html
-          sed -i "s#target_branch#${HEAD_REF}#g" report-gh.html
-          python .github/scripts/python_utils.py cppcheck_cleanup report-gh.html >> comment.html
-      - name: Upload logs
-        uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: cppcheck-report
-          path: |
-            report.html
-            report.xml
-      - name: Comment on PR
-        uses: ./.github/actions/upsert-pr-comment
-        with:
-          body-file: comment.html
-
   codeql:
     if: needs.check-for-pr.outputs.skip != 'true'
     runs-on: ubuntu-latest

.github/workflows/test_workflow.yml

@@ -103,7 +103,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: success()
         with:
-          name: test-linux-glibc-amd64 (${{ matrix.java_version }}, ${{ matrix.config }})] (build)
+          name: (build) test-linux-glibc-amd64 (${{ matrix.java_version }}, ${{ matrix.config }})
           path: build/
       - uses: actions/upload-artifact@v4
         if: failure()
@@ -117,7 +117,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: test-linux-glibc-amd64 (${{ matrix.java_version }}, ${{ matrix.config }}) (reports)
+          name: (reports) test-linux-glibc-amd64 (${{ matrix.java_version }}, ${{ matrix.config }})
           path: reports
 
   test-linux-musl-amd64:
@@ -206,7 +206,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: success()
         with:
-          name: test-linux-musl-amd64 (${{ matrix.java_version }}, ${{ matrix.config }})] (build)
+          name: (build) test-linux-musl-amd64 (${{ matrix.java_version }}, ${{ matrix.config }})
           path: build/
       - uses: actions/upload-artifact@v4
         if: failure()
@@ -220,7 +220,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: test-linux-musl-amd64 (${{ matrix.java_version }}, ${{ matrix.config }}) (reports)
+          name: (reports) test-linux-musl-amd64 (${{ matrix.java_version }}, ${{ matrix.config }})
           path: reports
 
   test-linux-glibc-aarch64:
@@ -317,7 +317,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: success()
         with:
-          name: test-linux-glibc-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }})] (build)
+          name: (build) test-linux-glibc-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }})
           path: build/
       - uses: actions/upload-artifact@v4
         if: failure()
@@ -331,7 +331,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: test-linux-glibc-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }}) (reports)
+          name: (reports) test-linux-glibc-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }})
           path: reports
 
   test-linux-musl-aarch64:
@@ -397,7 +397,7 @@ jobs:
        - uses: actions/upload-artifact@v4
          if: success()
          with:
-           name: test-linux-musl-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }})] (build)
+           name: (build) test-linux-musl-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }})
            path: build/
        - uses: actions/upload-artifact@v4
          if: failure()
@@ -411,5 +411,5 @@ jobs:
        - uses: actions/upload-artifact@v4
          if: failure()
          with:
-           name: test-linux-musl-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }}) (reports)
+           name: (reports) test-linux-musl-aarch64 (${{ matrix.java_version }}, ${{ matrix.config }})
            path: reports