-
Notifications
You must be signed in to change notification settings - Fork 15
Prepare 15.0.0 release #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cargo.toml
Outdated
| rust-version = "1.78.0" | ||
| edition = "2021" | ||
| version = "14.3.1" | ||
| version = "14.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this should be 15.0 given there's breaking changes in the crashtracking API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
We also increased the minimum rust version to 1.78 which drops support for windows 7 (which none of our products currently support anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the PR to bump to 15.0.0
VianneyRuhlmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe wait for someone with more expertise but LGTM
BenchmarksComparisonBenchmark execution time: 2025-01-17 14:53:45 Comparing candidate commit 018d6e7 in PR branch Found 7 performance improvements and 6 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/bad-name
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_trace/test_trace
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
bed4892 to
ad2c019
Compare
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 71.15% 71.17% +0.01%
==========================================
Files 319 319
Lines 46863 46863
==========================================
+ Hits 33346 33354 +8
+ Misses 13517 13509 -8
|
What does this PR do?
Motivation
The major version increase is necessary because of some breaking changes in the crashtracker APIs.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.