Skip to content

Conversation

@paullegranddc
Copy link
Contributor

@paullegranddc paullegranddc commented Jan 17, 2025

What does this PR do?

  • Bump workspace version to 15.0.0
  • Build configuration-ffi by default with the profiling artifacts so we can distribute it in the next release

Motivation

The major version increase is necessary because of some breaking changes in the crashtracker APIs.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@paullegranddc paullegranddc requested review from a team as code owners January 17, 2025 14:13
Cargo.toml Outdated
rust-version = "1.78.0"
edition = "2021"
version = "14.3.1"
version = "14.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this should be 15.0 given there's breaking changes in the crashtracking API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.
We also increased the minimum rust version to 1.78 which drops support for windows 7 (which none of our products currently support anyway)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the PR to bump to 15.0.0

Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wait for someone with more expertise but LGTM

@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-01-17 14:53:45

Comparing candidate commit 018d6e7 in PR branch paullgdc/prepare_14.4.0_release with baseline commit 95baa2e in branch main.

Found 7 performance improvements and 6 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+3.568µs; +3.620µs] or [+4.612%; +4.679%]
  • 🟥 throughput [-577936.529op/s; -569562.141op/s] or [-4.472%; -4.407%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+2.654µs; +2.724µs] or [+4.477%; +4.594%]
  • 🟥 throughput [-741728.787op/s; -722278.441op/s] or [-4.397%; -4.282%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟩 execution_time [-116.031µs; -115.420µs] or [-38.651%; -38.448%]
  • 🟩 throughput [+2082721.745op/s; +2097471.680op/s] or [+62.522%; +62.965%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟩 execution_time [-5.825µs; -5.771µs] or [-21.363%; -21.163%]
  • 🟩 throughput [+9852180.031op/s; +9958506.241op/s] or [+26.866%; +27.156%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟩 execution_time [-1.606µs; -1.572µs] or [-10.043%; -9.830%]
  • 🟩 throughput [+6825305.727op/s; +6971289.645op/s] or [+10.916%; +11.150%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+155.729µs; +156.089µs] or [+28.531%; +28.597%]
  • 🟥 throughput [-407585.972op/s; -406513.603op/s] or [-22.247%; -22.189%]

scenario:normalization/normalize_trace/test_trace

  • 🟩 execution_time [-35.812ns; -29.525ns] or [-11.604%; -9.567%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 700.218µs 701.736µs ± 0.736µs 701.697µs ± 0.517µs 702.233µs 702.735µs 703.249µs 706.342µs 0.66% 1.189 6.368 0.10% 0.052µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1415744.781op/s 1425038.566op/s ± 1492.401op/s 1425116.383op/s ± 1050.704op/s 1426147.018op/s 1427271.475op/s 1427932.526op/s 1428126.512op/s 0.21% -1.167 6.218 0.10% 105.529op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 472.984µs 474.163µs ± 1.072µs 474.040µs ± 0.273µs 474.291µs 474.763µs 477.034µs 484.215µs 2.15% 7.433 64.175 0.23% 0.076µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2065196.290op/s 2108988.488op/s ± 4689.598op/s 2109528.613op/s ± 1214.056op/s 2110751.052op/s 2112155.843op/s 2113640.058op/s 2114237.599op/s 0.22% -7.359 63.265 0.22% 331.605op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.357µs 191.008µs ± 0.262µs 190.975µs ± 0.136µs 191.114µs 191.445µs 191.898µs 192.154µs 0.62% 1.318 3.373 0.14% 0.019µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5204152.220op/s 5235380.739op/s ± 7175.148op/s 5236293.448op/s ± 3722.711op/s 5239616.919op/s 5244421.156op/s 5247760.120op/s 5253299.982op/s 0.32% -1.304 3.320 0.14% 507.360op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.194µs 46.362µs ± 0.052µs 46.368µs ± 0.032µs 46.397µs 46.446µs 46.459µs 46.471µs 0.22% -0.430 0.007 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21518601.012op/s 21569244.724op/s ± 24150.632op/s 21566817.114op/s ± 14900.559op/s 21582538.085op/s 21616203.829op/s 21626642.329op/s 21648064.069op/s 0.38% 0.436 0.015 0.11% 1707.708op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.924µs 49.204µs ± 0.096µs 49.215µs ± 0.058µs 49.263µs 49.350µs 49.409µs 49.422µs 0.42% -0.345 0.171 0.20% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20233988.635op/s 20323789.314op/s ± 39790.382op/s 20319127.072op/s ± 23745.286op/s 20346681.731op/s 20401882.864op/s 20422545.046op/s 20439937.947op/s 0.59% 0.357 0.180 0.20% 2813.605op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [701.634µs; 701.838µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1424831.733op/s; 1425245.398op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [474.015µs; 474.312µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2108338.555op/s; 2109638.421op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.972µs; 191.045µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5234386.333op/s; 5236375.146op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.355µs; 46.370µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21565897.679op/s; 21572591.770op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.190µs; 49.217µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20318274.750op/s; 20329303.878op/s] or [-0.027%; +0.027%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.766µs 39.399µs ± 1.145µs 38.870µs ± 0.047µs 38.949µs 41.904µs 41.960µs 42.420µs 9.13% 1.706 0.948 2.90% 0.081µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.240µs; 39.557µs] or [-0.403%; +0.403%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.380µs 5.455µs ± 0.037µs 5.470µs ± 0.021µs 5.483µs 5.503µs 5.506µs 5.558µs 1.61% -0.229 -1.203 0.68% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.450µs; 5.460µs] or [-0.094%; +0.094%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 260.637ns 275.934ns ± 17.066ns 266.876ns ± 4.361ns 291.249ns 311.495ns 314.808ns 318.842ns 19.47% 1.080 -0.340 6.17% 1.207ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [273.569ns; 278.300ns] or [-0.857%; +0.857%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.272µs 4.288µs ± 0.003µs 4.288µs ± 0.001µs 4.290µs 4.293µs 4.295µs 4.312µs 0.56% 1.629 17.972 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 231898308.415op/s 233187782.042op/s ± 172100.442op/s 233197516.446op/s ± 72207.874op/s 233270506.016op/s 233396966.042op/s 233539817.061op/s 234061815.605op/s 0.37% -1.591 17.768 0.07% 12169.339op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 89.201µs 90.758µs ± 0.697µs 90.740µs ± 0.396µs 91.138µs 91.771µs 92.219µs 96.223µs 6.04% 2.321 17.491 0.77% 0.049µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10392536.399op/s 11018971.717op/s ± 83271.598op/s 11020529.706op/s ± 48156.980op/s 11068632.603op/s 11140935.483op/s 11193059.885op/s 11210654.768op/s 1.73% -2.016 14.708 0.75% 5888.191op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.021µs 83.733µs ± 0.397µs 83.709µs ± 0.125µs 83.840µs 84.038µs 84.266µs 88.520µs 5.75% 8.794 104.446 0.47% 0.028µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11296919.283op/s 11942942.688op/s ± 54355.827op/s 11946119.419op/s ± 17804.414op/s 11962378.618op/s 11991370.749op/s 12020135.904op/s 12045142.786op/s 0.83% -8.385 98.071 0.45% 3843.537op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.274µs 4.289µs ± 0.004µs 4.289µs ± 0.001µs 4.290µs 4.293µs 4.294µs 4.337µs 1.13% 7.936 95.061 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230556599.421op/s 233143140.079op/s ± 220615.317op/s 233160409.364op/s ± 63157.878op/s 233222161.936op/s 233291755.981op/s 233432615.902op/s 233988517.906op/s 0.36% -7.839 93.728 0.09% 15599.859op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 80.495µs 80.966µs ± 0.132µs 80.965µs ± 0.060µs 81.025µs 81.148µs 81.430µs 81.516µs 0.68% 0.411 3.578 0.16% 0.009µs 1 200
credit_card/is_card_number/378282246310005 throughput 12267564.283op/s 12350965.376op/s ± 20073.785op/s 12350953.131op/s ± 9152.742op/s 12360152.108op/s 12379543.563op/s 12404628.556op/s 12423116.936op/s 0.58% -0.384 3.536 0.16% 1419.431op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.488µs 58.692µs ± 0.058µs 58.689µs ± 0.028µs 58.725µs 58.782µs 58.832µs 58.939µs 0.43% -0.038 2.410 0.10% 0.004µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16966734.782op/s 17038002.806op/s ± 16943.302op/s 17039007.170op/s ± 8090.307op/s 17045916.291op/s 17063987.480op/s 17084161.255op/s 17097469.575op/s 0.34% 0.051 2.404 0.10% 1198.072op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.433µs 6.444µs ± 0.005µs 6.443µs ± 0.002µs 6.446µs 6.453µs 6.454µs 6.455µs 0.18% 0.144 0.170 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154912718.204op/s 155188834.686op/s ± 109978.238op/s 155195390.561op/s ± 57505.711op/s 155250956.229op/s 155379410.533op/s 155429896.518op/s 155457073.827op/s 0.17% -0.140 0.169 0.07% 7776.636op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.272µs 4.289µs ± 0.003µs 4.289µs ± 0.002µs 4.291µs 4.294µs 4.296µs 4.299µs 0.23% -0.736 6.861 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232608082.213op/s 233133780.564op/s ± 150486.376op/s 233137752.220op/s ± 90852.381op/s 233229970.051op/s 233317148.549op/s 233463475.460op/s 234062426.416op/s 0.40% 0.752 6.946 0.06% 10640.994op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 68.822µs 69.773µs ± 0.419µs 69.762µs ± 0.311µs 70.080µs 70.452µs 70.692µs 70.835µs 1.54% 0.164 -0.590 0.60% 0.030µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14117391.008op/s 14332613.853op/s ± 86035.415op/s 14334500.650op/s ± 63900.795op/s 14397311.328op/s 14476263.133op/s 14489212.071op/s 14530250.620op/s 1.37% -0.140 -0.601 0.60% 6083.623op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 63.970µs 64.717µs ± 0.413µs 64.656µs ± 0.265µs 64.953µs 65.515µs 65.857µs 66.022µs 2.11% 0.675 0.403 0.64% 0.029µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15146478.170op/s 15452593.984op/s ± 98250.507op/s 15466571.326op/s ± 63250.270op/s 15516430.032op/s 15593102.528op/s 15623641.011op/s 15632408.060op/s 1.07% -0.638 0.334 0.63% 6947.360op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.275µs 4.289µs ± 0.002µs 4.289µs ± 0.001µs 4.291µs 4.293µs 4.294µs 4.295µs 0.14% -1.003 5.568 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232815086.817op/s 233137833.202op/s ± 127381.120op/s 233135631.253op/s ± 67990.365op/s 233203369.799op/s 233303778.213op/s 233484312.012op/s 233890937.218op/s 0.32% 1.013 5.628 0.05% 9007.205op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 61.611µs 61.976µs ± 0.117µs 61.968µs ± 0.069µs 62.038µs 62.186µs 62.304µs 62.330µs 0.58% 0.428 0.584 0.19% 0.008µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16043608.509op/s 16135375.023op/s ± 30350.988op/s 16137376.490op/s ± 17862.031op/s 16154796.055op/s 16180536.040op/s 16189898.528op/s 16230755.659op/s 0.58% -0.415 0.574 0.19% 2146.139op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.513µs 58.705µs ± 0.053µs 58.694µs ± 0.028µs 58.735µs 58.807µs 58.850µs 58.892µs 0.34% 0.491 1.393 0.09% 0.004µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16980241.751op/s 17034445.579op/s ± 15399.619op/s 17037375.718op/s ± 8005.449op/s 17044079.228op/s 17052348.917op/s 17070587.174op/s 17090200.479op/s 0.31% -0.482 1.392 0.09% 1088.918op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.413µs 6.445µs ± 0.005µs 6.444µs ± 0.002µs 6.447µs 6.451µs 6.457µs 6.461µs 0.26% -1.957 16.721 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154782762.689op/s 155168213.090op/s ± 108532.714op/s 155177533.539op/s ± 51686.461op/s 155217845.103op/s 155277913.117op/s 155337643.276op/s 155927848.764op/s 0.48% 1.989 16.911 0.07% 7674.422op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.288µs; 4.289µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [233163930.576op/s; 233211633.508op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [90.661µs; 90.854µs] or [-0.106%; +0.106%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [11007431.075op/s; 11030512.360op/s] or [-0.105%; +0.105%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [83.678µs; 83.788µs] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11935409.493op/s; 11950475.882op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [4.289µs; 4.290µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631 throughput [233112564.918op/s; 233173715.240op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.947µs; 80.984µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/378282246310005 throughput [12348183.343op/s; 12353747.410op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.684µs; 58.700µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [17035654.627op/s; 17040350.984op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.443µs; 6.444µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [155173592.760op/s; 155204076.612op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.289µs; 4.290µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [233112924.599op/s; 233154636.528op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.715µs; 69.832µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14320690.172op/s; 14344537.534op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [64.659µs; 64.774µs] or [-0.088%; +0.088%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15438977.408op/s; 15466210.559op/s] or [-0.088%; +0.088%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.289µs; 4.290µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233120179.404op/s; 233155487.001op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [61.960µs; 61.992µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16131168.668op/s; 16139581.378op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.697µs; 58.712µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [17032311.340op/s; 17036579.819op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.444µs; 6.445µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155153171.500op/s; 155183254.681op/s] or [-0.010%; +0.010%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.209ms 58.445ms ± 0.178ms 58.411ms ± 0.091ms 58.510ms 58.764ms 59.026ms 59.525ms 1.91% 2.226 7.911 0.30% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.420ms; 58.470ms] or [-0.042%; +0.042%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.369µs 3.294µs ± 1.471µs 3.097µs ± 0.027µs 3.121µs 3.738µs 14.332µs 15.375µs 396.48% 7.457 56.281 44.55% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.090µs; 3.498µs] or [-6.190%; +6.190%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.378µs 68.550µs ± 0.178µs 68.523µs ± 0.036µs 68.564µs 68.678µs 68.942µs 70.775µs 3.29% 9.977 120.142 0.26% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.525µs; 68.575µs] or [-0.036%; +0.036%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.971µs 27.441µs ± 14.464µs 18.550µs ± 0.479µs 36.483µs 46.673µs 59.874µs 149.052µs 703.49% 3.922 26.960 52.58% 1.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.436µs; 29.446µs] or [-7.305%; +7.305%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.030µs 138.801µs ± 0.323µs 138.773µs ± 0.155µs 138.929µs 139.510µs 139.819µs 140.701µs 1.39% 1.733 6.681 0.23% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.756µs; 138.846µs] or [-0.032%; +0.032%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 180.704µs 184.475µs ± 1.747µs 184.192µs ± 1.231µs 185.612µs 187.532µs 188.518µs 189.284µs 2.76% 0.506 -0.440 0.94% 0.124µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5283080.670op/s 5421266.166op/s ± 51117.460op/s 5429129.979op/s ± 36276.386op/s 5461026.701op/s 5490324.441op/s 5509540.314op/s 5533904.156op/s 1.93% -0.469 -0.479 0.94% 3614.550op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 21.150µs 21.471µs ± 0.166µs 21.438µs ± 0.098µs 21.556µs 21.781µs 21.934µs 22.090µs 3.04% 1.051 1.242 0.77% 0.012µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 45268866.376op/s 46577285.037op/s ± 357016.816op/s 46647165.826op/s ± 214202.120op/s 46826288.755op/s 47034140.688op/s 47137682.599op/s 47281285.987op/s 1.36% -1.002 1.101 0.76% 25244.901op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 14.243µs 14.405µs ± 0.079µs 14.406µs ± 0.062µs 14.459µs 14.535µs 14.581µs 14.618µs 1.47% 0.210 -0.494 0.55% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 68411077.891op/s 69423565.394op/s ± 381879.449op/s 69417723.745op/s ± 297741.874op/s 69737809.028op/s 70053540.060op/s 70185473.958op/s 70208579.818op/s 1.14% -0.186 -0.510 0.55% 27002.955op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [184.233µs; 184.717µs] or [-0.131%; +0.131%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5414181.778op/s; 5428350.555op/s] or [-0.131%; +0.131%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [21.448µs; 21.494µs] or [-0.107%; +0.107%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [46527805.940op/s; 46626764.134op/s] or [-0.106%; +0.106%] None None None
normalization/normalize_name/normalize_name/good execution_time [14.394µs; 14.416µs] or [-0.076%; +0.076%] None None None
normalization/normalize_name/normalize_name/good throughput [69370640.575op/s; 69476490.213op/s] or [-0.076%; +0.076%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.685µs 2.731µs ± 0.018µs 2.728µs ± 0.008µs 2.737µs 2.776µs 2.782µs 2.785µs 2.10% 1.168 2.453 0.65% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.728µs; 2.733µs] or [-0.090%; +0.090%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 018d6e7 1737124649 paullgdc/prepare_14.4.0_release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.510ms 6.523ms ± 0.016ms 6.521ms ± 0.004ms 6.525ms 6.533ms 6.606ms 6.616ms 1.46% 4.321 19.829 0.24% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.521ms; 6.525ms] or [-0.033%; +0.033%] None None None

Baseline

Omitted due to size.

@paullegranddc paullegranddc force-pushed the paullgdc/prepare_14.4.0_release branch from bed4892 to ad2c019 Compare January 17, 2025 14:30
@paullegranddc paullegranddc changed the title Prepare 14.4.0 release Prepare 15.0.0 release Jan 17, 2025
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@paullegranddc paullegranddc enabled auto-merge (squash) January 17, 2025 15:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (95baa2e) to head (018d6e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   71.15%   71.17%   +0.01%     
==========================================
  Files         319      319              
  Lines       46863    46863              
==========================================
+ Hits        33346    33354       +8     
+ Misses      13517    13509       -8     
Components Coverage Δ
crashtracker 38.00% <ø> (ø)
crashtracker-ffi 5.63% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.48% <ø> (ø)
data-pipeline-ffi 90.08% <ø> (ø)
ddcommon 80.24% <ø> (ø)
ddcommon-ffi 62.11% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.29% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.29% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 41.79% <ø> (-0.12%) ⬇️
sidecar-ffi 10.78% <ø> (-0.89%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 94.13% <ø> (ø)

@paullegranddc paullegranddc merged commit 0ef4986 into main Jan 17, 2025
30 of 31 checks passed
@paullegranddc paullegranddc deleted the paullgdc/prepare_14.4.0_release branch January 17, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants