Skip to content

Commit 76dba20

Browse files
committed
8368821: Test java/net/httpclient/http3/GetHTTP3Test.java intermittently fails with java.io.IOException: QUIC endpoint closed
Reviewed-by: dfuchs
1 parent c3fbbfa commit 76dba20

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

test/jdk/java/net/httpclient/http3/GetHTTP3Test.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import java.net.http.HttpResponse;
3434
import java.net.http.HttpResponse.BodyHandlers;
3535
import java.nio.charset.StandardCharsets;
36-
import java.time.Duration;
3736
import java.util.HashMap;
3837
import java.util.List;
3938
import java.util.Map;
@@ -47,6 +46,7 @@
4746
import java.util.concurrent.atomic.AtomicLong;
4847
import javax.net.ssl.SSLContext;
4948

49+
import jdk.test.lib.Utils;
5050
import jdk.test.lib.net.SimpleSSLContext;
5151
import jdk.httpclient.test.lib.common.HttpServerAdapters;
5252
import jdk.httpclient.test.lib.http2.Http2TestServer;
@@ -74,8 +74,9 @@
7474
* @library /test/lib /test/jdk/java/net/httpclient/lib
7575
* @build jdk.test.lib.net.SimpleSSLContext
7676
* jdk.httpclient.test.lib.common.HttpServerAdapters
77+
* jdk.test.lib.Utils
7778
* @compile ../ReferenceTracker.java
78-
* @run testng/othervm/timeout=60 -Djdk.internal.httpclient.debug=true
79+
* @run testng/othervm -Djdk.internal.httpclient.debug=true
7980
* -Djdk.httpclient.HttpClient.log=requests,responses,errors
8081
* GetHTTP3Test
8182
* @summary Basic HTTP/3 GET test
@@ -216,7 +217,6 @@ private HttpClient makeNewClient() {
216217
.proxy(HttpClient.Builder.NO_PROXY)
217218
.executor(executor)
218219
.sslContext(sslContext)
219-
.connectTimeout(Duration.ofSeconds(10))
220220
.build();
221221
return TRACKER.track(client);
222222
}
@@ -348,7 +348,7 @@ public void testAsync(String uri, Version firstRequestVersion, boolean sameClien
348348
var tracker = TRACKER.getTracker(client);
349349
client = null;
350350
System.gc();
351-
AssertionError error = TRACKER.check(tracker, 1000);
351+
AssertionError error = TRACKER.check(tracker, Utils.adjustTimeout(1000));
352352
if (error != null) throw error;
353353
}
354354
System.out.println("test: DONE");
@@ -394,7 +394,7 @@ public void testSync(String h3URI) throws Exception {
394394
var tracker = TRACKER.getTracker(client);
395395
client = null;
396396
System.gc();
397-
AssertionError error = TRACKER.check(tracker, 1000);
397+
AssertionError error = TRACKER.check(tracker, Utils.adjustTimeout(1000));
398398
if (error != null) throw error;
399399
}
400400

@@ -423,7 +423,7 @@ public void teardown() throws Exception {
423423
sharedClient == null ? null : sharedClient.toString();
424424
sharedClient = null;
425425
Thread.sleep(100);
426-
AssertionError fail = TRACKER.check(500);
426+
AssertionError fail = TRACKER.check(Utils.adjustTimeout(1000));
427427
try {
428428
h3TestServer.stop();
429429
} finally {

test/jdk/java/net/httpclient/http3/PostHTTP3Test.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.net.http.HttpResponse;
3939
import java.net.http.HttpResponse.BodyHandlers;
4040
import java.nio.charset.StandardCharsets;
41-
import java.time.Duration;
4241
import java.util.HashMap;
4342
import java.util.List;
4443
import java.util.Map;
@@ -53,6 +52,7 @@
5352
import java.util.stream.Stream;
5453
import javax.net.ssl.SSLContext;
5554

55+
import jdk.test.lib.Utils;
5656
import jdk.test.lib.net.SimpleSSLContext;
5757
import jdk.httpclient.test.lib.common.HttpServerAdapters;
5858
import jdk.httpclient.test.lib.http2.Http2TestServer;
@@ -79,6 +79,7 @@
7979
* @library /test/lib /test/jdk/java/net/httpclient/lib
8080
* @build jdk.test.lib.net.SimpleSSLContext
8181
* jdk.httpclient.test.lib.common.HttpServerAdapters
82+
* jdk.test.lib.Utils
8283
* @compile ../ReferenceTracker.java
8384
* @run testng/othervm -Djdk.internal.httpclient.debug=true
8485
* -Djdk.httpclient.HttpClient.log=requests,responses,errors
@@ -221,7 +222,6 @@ private HttpClient makeNewClient() {
221222
.proxy(HttpClient.Builder.NO_PROXY)
222223
.executor(executor)
223224
.sslContext(sslContext)
224-
.connectTimeout(Duration.ofSeconds(10))
225225
.build();
226226
return TRACKER.track(client);
227227
}
@@ -375,7 +375,7 @@ public void testAsync(String uri, Version firstRequestVersion, boolean sameClien
375375
var tracker = TRACKER.getTracker(client);
376376
client = null;
377377
System.gc();
378-
AssertionError error = TRACKER.check(tracker, 1000);
378+
AssertionError error = TRACKER.check(tracker, Utils.adjustTimeout(1000));
379379
if (error != null) throw error;
380380
}
381381
System.out.println("test: DONE");
@@ -437,7 +437,7 @@ public void testSync(String h3URI) throws Exception {
437437
var tracker = TRACKER.getTracker(client);
438438
client = null;
439439
System.gc();
440-
AssertionError error = TRACKER.check(tracker, 1000);
440+
AssertionError error = TRACKER.check(tracker, Utils.adjustTimeout(1000));
441441
if (error != null) throw error;
442442
}
443443

@@ -466,7 +466,7 @@ public void teardown() throws Exception {
466466
sharedClient == null ? null : sharedClient.toString();
467467
sharedClient = null;
468468
Thread.sleep(100);
469-
AssertionError fail = TRACKER.check(500);
469+
AssertionError fail = TRACKER.check(Utils.adjustTimeout(1000));
470470
try {
471471
h3TestServer.stop();
472472
} finally {

0 commit comments

Comments
 (0)