8345267: Fix memory leak in JVMCIEnv dtor

Doug Simon · Doug Simon · commit b8233989e760 · 2024-12-02T13:56:30.000Z
Reviewed-by: simonis, kbarrett
diff --git a/src/hotspot/share/jvmci/jvmciEnv.cpp b/src/hotspot/share/jvmci/jvmciEnv.cpp
@@ -613,7 +613,7 @@ JVMCIEnv::~JVMCIEnv() {
   if (_init_error_msg != nullptr) {
     // The memory allocated in libjvmci was not allocated with os::malloc
     // so must not be freed with os::free.
-    ALLOW_C_FUNCTION(::free((void*) _init_error_msg));
+    ALLOW_C_FUNCTION(::free, ::free((void*) _init_error_msg);)
   }
   if (_init_error != JNI_OK) {
     return;

Original file line number	Diff line number	Diff line change
`@@ -613,7 +613,7 @@ JVMCIEnv::~JVMCIEnv() {`
`613`	`613`	`if (_init_error_msg != nullptr) {`
`614`	`614`	`// The memory allocated in libjvmci was not allocated with os::malloc`
`615`	`615`	`// so must not be freed with os::free.`
`616`		`- ALLOW_C_FUNCTION(::free((void*) _init_error_msg));`
	`616`	`+ ALLOW_C_FUNCTION(::free, ::free((void*) _init_error_msg);)`
`617`	`617`	`}`
`618`	`618`	`if (_init_error != JNI_OK) {`
`619`	`619`	`return;`