Remove prefix library override for test files (#5862)

Author: nccatoni

tests/test_the_test/test_compute_libraries_and_scenarios.py

@@ -235,8 +235,16 @@ def test_library_tag(self):
     def test_wrong_library_tag(self):
         inputs = build_inputs(["utils/build/docker/python/test.Dockerfile"])
 
-        with pytest.raises(ValueError):
-            process(inputs)
+        strings_out = process(inputs)
+
+        assert strings_out == [
+            'library_matrix=[{"library": "java", "version": "prod"}, {"library": "python", "version": "prod"}, {"library": "java", "version": "dev"}, {"library": "python", "version": "dev"}]',
+            'libraries_with_dev=["java", "python"]',
+            "desired_execution_time=3600",
+            "rebuild_lambda_proxy=false",
+            'scenarios="DEFAULT"',
+            'scenarios_groups="end_to_end,open_telemetry"',
+        ]
 
     @set_env("GITHUB_PR_TITLE", "[java@main] Some title")
     def test_wrong_library_tag_with_branch(self):
@@ -260,9 +268,9 @@ def test_wrong_library_tag_with_test_file(self):
         strings_out = process(inputs)
 
         assert strings_out == [
-            'library_matrix=[{"library": "java", "version": "prod"}, {"library": "java", "version": "dev"}]',
-            'libraries_with_dev=["java"]',
-            "desired_execution_time=600",
+            all_lib_matrix,
+            all_lib_with_dev,
+            "desired_execution_time=3600",
             "rebuild_lambda_proxy=false",
             'scenarios="DEFAULT,INSTALLER_NOT_SUPPORTED_AUTO_INJECTION"',
             'scenarios_groups=""',

utils/scripts/compute_libraries_and_scenarios.py

@@ -155,26 +155,9 @@ def compute_impacted(self, modified_file: str, param: Param | None) -> None:
         logger.warning(f"Unknown file {modified_file} was detected, activating all libraries.")
         self.impacted |= LIBRARIES
 
-    def is_manual(self, file: str) -> bool:
-        if not self.user_choice:
-            return False
-
-        if self.branch_selector or len(self.impacted) == 0:
-            return True
-        # user specified a library in the PR title
-        # and there are some impacted libraries
-        if file.startswith("tests/") or self.impacted == {self.user_choice}:
-            # modification in tests files are complex, trust user
-            return True
-        # only acceptable use case : impacted library exactly matches user choice
-        raise ValueError(
-            f"""File {file} is modified, and it may impact {", ".join(self.impacted)}.
-                    Please remove the PR title prefix [{self.user_choice}]"""
-        )
-
     def add(self, file: str, param: Param | None) -> None:
         self.compute_impacted(file, param)
-        if not self.is_manual(file):
+        if not (self.user_choice and self.branch_selector):
             self.selected |= self.impacted
 
     def get_outputs(self) -> dict[str, Any]: