Skip to content

Commit 1e05d23

Browse files
committed
fix: preserve version selection when loading more releases
When clicking 'Load more...' to fetch additional releases, the version dropdown would show a blank selection after removing the 'Load more...' item and adding new versions. This fix saves the current selection index before removing the last item and restores it after adding new releases, ensuring the user's selected version remains visible during pagination.
1 parent f881e4c commit 1e05d23

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

pupgui2/pupgui2installdialog.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ def _threadupdate_releases_thread():
9191
if self.loaded_page == 1:
9292
self.ui.comboCompatToolVersion.clear()
9393
else:
94+
# Save the current selection before removing "Load more..."
95+
current_index = self.ui.comboCompatToolVersion.currentIndex()
9496
self.ui.comboCompatToolVersion.removeItem(self.ui.comboCompatToolVersion.count() - 1)
9597

9698
vers = self.current_ct_obj['installer'].fetch_releases(count=RELEASES_PER_PAGE, page=self.loaded_page)
@@ -102,7 +104,11 @@ def _threadupdate_releases_thread():
102104
# Stops install dialog UI elements from being enabled when rate-limited to prevent switching/installing tools
103105
if len(vers) > 0:
104106
self.ui.comboCompatToolVersion.addItems(vers)
105-
self.ui.comboCompatToolVersion.setCurrentIndex(0)
107+
if self.loaded_page == 1:
108+
self.ui.comboCompatToolVersion.setCurrentIndex(0)
109+
else:
110+
# Restore the previous selection after loading more
111+
self.ui.comboCompatToolVersion.setCurrentIndex(current_index)
106112

107113
if self.more_releases_loadable:
108114
self.ui.comboCompatToolVersion.addItem(self.tr('Load more...'))

0 commit comments

Comments
 (0)