"progressed is not a function" error on apk install

[slankes]

I stumbled over an issue that when plugging in a phone, APK installation would fail and the log would have a message "progressed is not a function". When I removed the .progressed call from lib/units/device/resources/service.js it started working.

So I submitted this pull request: #827

I'm opening this ticket to get to the bottom of the issue.

The progressed function comes from bluebird.js. According to the changelog shipped with the container, version 2.11.0 (released 8.5 years) ago is being used. This version does have a progressed function.

Looking at the bluebird changelog I see the following:

• progress is deprecated in bluebird and has been removed since release 3.0 (sometime in 2015)
• they are suggesting to use native node promises instead of bluebird.js wherever possible

I am not very fluent in javascript but for me the only reason for the error I am seeing is that something pulls in a newer version of bluescript.js and the one shipped in the container is not used.

I have no idea why it does work for others and only breaks for me though.

Any ideas are appreciated.

[jmhunter]

I'm having the same issue, having just upgraded stf here.

Extract from my docker logs (device serial number sanitised):

stf  | 2025-01-31T16:41:49.057Z FTL/device 17564 [SN1234XYZ] Setup had an error TypeError: adb.uninstall(...).timeout(...).then(...).progressed is not a function
stf  |     at /app/lib/units/device/resources/service.js:92:14
stf  |     at tryCatcher (/app/node_modules/@devicefarmer/adbkit/node_modules/bluebird/js/release/util.js:16:23)
[...]

I manually applied the patch from #827 and stf started working again straight away.

I'm using the sample docker-compose file from master/docker-compose.yaml

In case it helps, the stf docker image I'm currently running is e54b19cb746e (which was latest from just now, even though the hash doesn't match the one shown on hub.docker.com); the previous version that worked fine was from 10 months ago so would be 3.6.8 and is shown in my docker as c8851e551196.

How I manually patched, if anyone else also needs to do this

For anyone else needing to manually patch for now, I used `docker exec -it --user root stf /bin/bash` to connect to the stf container, then `apt update; apt install --no-install-recommends vim` to install an editor, finally followed by manually editing the file as per #827 and removing the `.progressed` section.

[denis99999]

@slankes , @jmhunter , I reopened the PR #827 for comment and merging.