Skip to content

Commit df1ba34

Browse files
authored
Doc updates (#880)
* Link to Takumi in the README Signed-off-by: Nico Burns <[email protected]> * Update docs to use just rather than cargo Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]>
1 parent ef85431 commit df1ba34

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ The PR review process is completely open: help us by commenting on, testing and
1414

1515
If you'd like to help on a consistent basis or are interested in project management, create a Discussions post, and we'll be happy to hand out triage rights.
1616

17+
## The "just" task runner
18+
19+
Taffy uses a task runner called [just](github.com/casey/just) to run tasks. This can be installed by running `cargo install --locked just`. This is just necessary for the commands of the form `just ...` to work.
20+
If you do you not want to install `just` then you can peak into the `justfile` in the root of this repo to see the equivalent cargo command, which will usually be of the form `cargo run -rp <package> ...`.
21+
1722
## Testing
1823

1924
### Running tests
@@ -32,7 +37,7 @@ If you are Ubuntu, you will have to install `openssl` first,
3237
and then can follow [these instructions](https://tecadmin.net/setup-selenium-chromedriver-on-ubuntu/).
3338
Be sure that your Chrome version matches the downloaded `chromedriver` version!
3439

35-
Once you have chromedriver installed and available in `PATH` you can re-generate all tests by running `cargo gentest`. You should not manually update the tests in `tests/generated`. Instead, fix the script in `scripts/gentest/` and re-generate them. This can happen after a refactor. It can be helpful to commit the updated tests in a dedicated commit so that they can be easier to ignore during review.
40+
Once you have chromedriver installed and available in `PATH` you can re-generate all tests by running `just gentest`. You should not manually update the tests in `tests/generated`. Instead, fix the script in `scripts/gentest/` and re-generate them. This can happen after a refactor. It can be helpful to commit the updated tests in a dedicated commit so that they can be easier to ignore during review.
3641

3742
To add a new test case add another HTML file to `/test_fixtures` following the current tests as a template for new tests.
3843

@@ -85,4 +90,4 @@ To add a new test case add another HTML file to `/test_fixtures` following the c
8590
## Benchmarking
8691

8792
Benchmarks build on the same infrastructure as testing, and actually benchmarks are automatically generated from test fixtures just like tests.
88-
Run `cargo xbench` to run benchmarks locally. To run head-to-head benchmarks with Yoga, run `cargo xbench --features yoga`. You will need `libclang-dev` or the xcode commandline tools installed in order to run the yoga benchmarks.
93+
Run `just bench` to run benchmarks locally. To run head-to-head benchmarks with Yoga, run `just bench --features yoga`. You will need `libclang-dev` or the xcode commandline tools installed in order to run the yoga benchmarks.

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Right now, it powers:
1414
- [Servo](https://github.com/servo/servo): an alternative web browser
1515
- [Blitz](https://github.com/DioxusLabs/blitz): a radically modular web engine
1616
- [Bevy](https://bevyengine.org/): an ergonomic, ECS-first Rust game engine
17+
- [Takumi](https://github.com/kane50613/takumi): Renders your React components to images
1718
- [iocraft](https://github.com/ccbrown/iocraft): crafting beautiful interfaces for the terminal
1819
- The [Lapce](https://lapce.dev/) text editor via the [Floem](https://github.com/lapce/floem) UI framework
1920
- The [Zed](https://zed.dev/) text editor via the [GPUI](https://github.com/zed-industries/zed/tree/main/crates/gpui) UI framework

0 commit comments

Comments
 (0)