Skip to content

VMM UpgradeApp does not update allowed_envs #385

@Evrard-Nil

Description

@Evrard-Nil

When updating a VM's compose file and environment variable through VMM, new environment variables are not taken into account.
Checking the VM's shared/app-compose.json, the list of allowed env vars is not updated. E.g.

{
    "manifest_version": 2,
    "name": "vpc-server-prod",
    "runner": "docker-compose",
    "docker_compose_file": "services:\n  dstack-service:\n    image: nearaidev/dstack-service@sha256:fad3355c3e0ad1001cfac8a02b0037c546ea011c9294c972158700fe17082d14\n    restart: unless-stopped\n    ports:\n      - \"2379:2379\"\n    volumes:\n      - /var/run/docker.sock:/var/run/docker.sock\n      - /var/run/dstack.sock:/var/run/dstack.sock\n    environment:\n      - VPC_SERVER_ENABLED=true\n      - VPC_ALLOWED_APPS=${ETCD_APP_ID},${POSTGRES_APP_ID},${CLOUD_API_APP_ID},${INGRESS_APP_ID},${SECONDARY_INGRESS_APP_ID}\n",
    "kms_enabled": true,
    "gateway_enabled": true,
    "local_key_provider_enabled": false,
    "key_provider_id": "",
    "public_logs": true,
    "public_sysinfo": true,
    "allowed_envs": [
        "VPC_SERVER_APP_ID",
        "ETCD_APP_ID",
        "POSTGRES_PRIMARY_APP_ID",
        "POSTGRES_APP_ID",
        "CLOUD_API_APP_ID",
        "INGRESS_APP_ID"
    ],
    "no_instance_id": false,
    "secure_time": false
}

SECONDARY_INGRESS_APP_ID is the new var here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions