Skip to content

Commit 5ec0f0a

Browse files
author
xiaosong.ye
committed
fix: 更改部分单元测试代码
1 parent e4c4a8d commit 5ec0f0a

File tree

3 files changed

+29
-30
lines changed

3 files changed

+29
-30
lines changed

src/checkbox/__test__/Checkbox_test.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ test('should render checked checkbox if checkboxGroup value contains the same la
5353
test('should display indeterminate mark when checkbox is an indeterminate state', () => {
5454
const wrapper = mount(
5555
<Checkbox
56-
indeterminate={true}/>
56+
indeterminate={true} />
5757
)
5858
expect(wrapper.find('.el-checkbox__input').hasClass('is-indeterminate')).toEqual(true)
5959
})
@@ -77,7 +77,7 @@ test('should limited to max and min value', () => {
7777
)
7878

7979
//test checked length
80-
expect(wrapper.find('.el-checkbox__input .is-checked').length).toBe(2)
80+
expect(wrapper.find('.el-checkbox .el-checkbox__input.is-checked').length).toBe(2)
8181

8282

8383
const Input = document.createElement('input');
@@ -87,7 +87,7 @@ test('should limited to max and min value', () => {
8787
wrapper.find('input[type="checkbox"]').forEach(e => {
8888
if (!e.prop('checked')) {
8989
e.simulate('change', { target: Input });
90-
expect(wrapper.find('.el-checkbox__input .is-checked').length).toBe(2)
90+
expect(wrapper.find('.el-checkbox__input.is-checked').length).toBe(2)
9191
}
9292
})
9393

@@ -96,7 +96,7 @@ test('should limited to max and min value', () => {
9696
wrapper.find('input[type="checkbox"]').forEach(e => {
9797
if (e.prop('checked')) {
9898
e.simulate('change', { target: Input })
99-
expect(wrapper.find('.el-checkbox__input .is-checked').length).toBe(1)
99+
expect(wrapper.find('.el-checkbox__input.is-checked').length).toBe(1)
100100
}
101101
})
102102
})

src/input/Input.jsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,17 +70,15 @@ export default class Input extends Component {
7070

7171
handleBlur(e: SyntheticEvent): void {
7272
const { onBlur } = this.props
73-
if (this.props.trim) this.handleTrim(e)
73+
// if (this.props.trim) this.handleTrim()
7474
if (onBlur) onBlur(e)
7575
}
7676

77-
handleTrim(e: SyntheticEvent): void {
77+
handleTrim(): void {
78+
this.refs.input.value = this.refs.input.value.trim()
7879
if(this.props.onChange) {
7980
// this's for controlled components
80-
this.props.onChange(e.target.value.trim())
81-
} else {
82-
// this's for uncontrolled components
83-
this.refs.input.value = this.refs.input.value.trim()
81+
this.props.onChange(this.refs.input.value.trim())
8482
}
8583
}
8684

src/switch/__test__/switch_test.jsx

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ test('Basic usage', () => {
1111
</Switch>
1212
);
1313

14-
expect(switch1.find('div .el-switch__label').at(0).text()).toEqual('');
15-
expect(switch1.find('div .el-switch__label').at(1).text()).toEqual('');
16-
expect(switch1.find('label .el-switch').at(0).hasClass('is-checked')).toEqual(true);
14+
expect(switch1.find('label.el-switch .el-switch__label').at(0).text()).toEqual('');
15+
expect(switch1.find('label.el-switch .el-switch__label').at(1).text()).toEqual('');
16+
expect(switch1.find('label.el-switch').hasClass('is-checked')).toEqual(true);
1717

1818
// switch off
1919
switch1.find('input').simulate('change', {target: {value: false}});
2020

21-
expect(switch1.find('div .el-switch__label').at(0).text()).toEqual('');
22-
expect(switch1.find('div .el-switch__label').at(1).text()).toEqual('');
23-
expect(switch1.find('label .el-switch').at(0).hasClass('is-checked')).toEqual(false);
21+
expect(switch1.find('label.el-switch .el-switch__label').at(0).text()).toEqual('');
22+
expect(switch1.find('label.el-switch .el-switch__label').at(1).text()).toEqual('');
23+
expect(switch1.find('label.el-switch').at(0).hasClass('is-checked')).toEqual(false);
2424

2525
const switch2 = mount(
2626
<Switch
@@ -30,20 +30,21 @@ test('Basic usage', () => {
3030
</Switch>
3131
);
3232

33-
expect(switch2.find('label .el-switch').at(0).hasClass('is-checked')).toEqual(true);
34-
expect(switch2.find('div .el-switch__label').at(0).text()).toEqual('ON');
35-
expect(switch2.find('div .el-switch__label').at(1).text()).toEqual('OFF');
36-
expect(switch2.find('div .el-switch__label').at(0).prop('style').display).toEqual(undefined);
37-
expect(switch2.find('div .el-switch__label').at(1).prop('style').display).toEqual('none');
33+
expect(switch2.find('label.el-switch').at(0).hasClass('is-checked')).toEqual(true);
34+
expect(switch2.find('label.el-switch .el-switch__label').at(0).text()).toEqual('ON');
35+
expect(switch2.find('label.el-switch .el-switch__label').at(1).text()).toEqual('OFF');
36+
expect(switch2.find('label.el-switch .el-switch__label').at(0).prop('style').display).toEqual(undefined);
37+
expect(switch2.find('label.el-switch .el-switch__label').at(1).prop('style').display).toEqual('none');
3838

3939
// switch off
4040
switch2.find('input[type="checkbox"]').simulate('change', {target: {value: false}});
4141

42-
expect(switch2.find('label .el-switch').at(0).hasClass('is-checked')).toEqual(false);
43-
expect(switch2.find('div .el-switch__label').at(0).text()).toEqual('ON');
44-
expect(switch2.find('div .el-switch__label').at(1).text()).toEqual('OFF');
45-
expect(switch2.find('div .el-switch__label').at(0).prop('style').display).toEqual('none');
46-
expect(switch2.find('div .el-switch__label').at(1).prop('style').display).toEqual(undefined);
42+
expect(switch2.find('label.el-switch').at(0).hasClass('is-checked')).toEqual(false);
43+
expect(switch2.find('label.el-switch .el-switch__label').at(0).text()).toEqual('ON');
44+
expect(switch2.find('label.el-switch .el-switch__label').at(1).text()).toEqual('OFF');
45+
expect(switch2.find('label.el-switch .el-switch__label').at(0).prop('style').display).toEqual('none');
46+
expect(switch2.find('label.el-switch .el-switch__label').at(1).prop('style').display).toEqual(undefined);
47+
4748
});
4849

4950
test('Extended value types', () => {
@@ -73,7 +74,7 @@ test('Extended value types', () => {
7374
</Tooltip>
7475
</div>);
7576

76-
expect(component.find('label .el-switch .el-switch--wide').at(0).hasClass('is-checked')).toEqual(true);
77+
expect(component.find('label.el-switch.el-switch--wide').at(0).hasClass('is-checked')).toEqual(true);
7778
expect(component.find('div .el-switch__label').at(0).text()).toEqual('ON');
7879
expect(component.find('div .el-switch__label').at(1).text()).toEqual('OFF');
7980
expect(component.find('div .el-switch__label').at(0).prop('style').display).toEqual(undefined);
@@ -83,7 +84,7 @@ test('Extended value types', () => {
8384
// switch off
8485
component.find('input[type="checkbox"]').simulate('change', {target: {value: false}});
8586

86-
expect(component.find('label .el-switch .el-switch--wide').at(0).hasClass('is-checked')).toEqual(false);
87+
expect(component.find('label.el-switch.el-switch--wide').at(0).hasClass('is-checked')).toEqual(false);
8788
expect(component.find('div .el-switch__label').at(0).text()).toEqual('ON');
8889
expect(component.find('div .el-switch__label').at(1).text()).toEqual('OFF');
8990
expect(component.find('div .el-switch__label').at(0).prop('style').display).toEqual('none');
@@ -101,7 +102,7 @@ test('Disabled', () => {
101102
</Switch>
102103
);
103104

104-
expect(switch1.find('label .el-switch').at(0).hasClass('is-disabled')).toEqual(true);
105+
expect(switch1.find('label.el-switch').at(0).hasClass('is-disabled')).toEqual(true);
105106
expect(switch1.find('input[type="checkbox"]').at(0).prop('disabled')).toEqual(true);
106107

107108
const switch2 = mount(
@@ -110,7 +111,7 @@ test('Disabled', () => {
110111
disabled>
111112
</Switch>);
112113

113-
expect(switch2.find('label .el-switch').at(0).hasClass('is-disabled')).toEqual(true);
114+
expect(switch2.find('label.el-switch').at(0).hasClass('is-disabled')).toEqual(true);
114115
expect(switch2.find('input[type="checkbox"]').at(0).prop('disabled')).toEqual(true);
115116

116117
});

0 commit comments

Comments
 (0)