Fixes: #486

Author: caphrim007

cmd/k8s-bigip-ctlr/main.go

@@ -292,6 +292,15 @@ func init() {
 	_init()
 }
 
+func hasCommonPartition(partitions []string) bool {
+	for _, x := range partitions {
+		if x == "Common" {
+			return true
+		}
+	}
+	return false
+}
+
 func verifyArgs() error {
 	*logLevel = strings.ToUpper(*logLevel)
 	logErr := initLogger(*logLevel)
@@ -305,6 +314,11 @@ func verifyArgs() error {
 
 	if len(*bigIPPartitions) == 0 {
 		return fmt.Errorf("missing a BIG-IP partition")
+	} else if len(*bigIPPartitions) > 0 {
+		err := hasCommonPartition(*bigIPPartitions)
+		if false != err {
+			return fmt.Errorf("Common cannot be one of the specified partitions.")
+		}
 	}
 
 	if (len(*bigIPURL) == 0 || len(*bigIPUsername) == 0 ||

cmd/k8s-bigip-ctlr/main_test.go

@@ -253,6 +253,38 @@ var _ = Describe("Main Tests", func() {
 			Expect(isNodePort).To(BeFalse())
 		})
 
+		It("verifies Common not in list of partitions", func() {
+			defer _init()
+			os.Args = []string{
+				"./bin/k8s-bigip-ctlr",
+				"--namespace=testing",
+				"--bigip-partition=velcro1",
+				"--bigip-partition=velcro2",
+				"--bigip-password=admin",
+				"--bigip-url=bigip.example.com",
+				"--bigip-username=admin",
+				"--vs-snat-pool-name=test-snat-pool"}
+			flags.Parse(os.Args)
+			argError := verifyArgs()
+			Expect(argError).To(BeNil())
+			hasCommon := hasCommonPartition(*bigIPPartitions)
+			Expect(hasCommon).To(BeFalse())
+
+			os.Args = []string{
+				"./bin/k8s-bigip-ctlr",
+				"--namespace=testing",
+				"--bigip-partition=velcro1",
+				"--bigip-partition=Common",
+				"--bigip-partition=velcro2",
+				"--bigip-password=admin",
+				"--bigip-url=bigip.example.com",
+				"--bigip-username=admin",
+				"--vs-snat-pool-name=test-snat-pool"}
+			flags.Parse(os.Args)
+			hasCommon = hasCommonPartition(*bigIPPartitions)
+			Expect(hasCommon).To(BeTrue())
+		})
+
 		It("verifies args labels", func() {
 			defer _init()
 			os.Args = []string{