Fix #718 - Namespaces that start with a number cause errors

Author: f5tsomanchi

pkg/appmanager/appManager_test.go

@@ -4200,6 +4200,30 @@ var _ = Describe("AppManager Tests", func() {
 				Expect(err).ToNot(BeNil())
 			})
 
+			// This test case validates namespace name update funcitonality
+			// where, a name starting with a 'number' is prefixed with 'cfgmap_<name>'
+			It("Check namespace name starting with number", func() {
+				NumNSname := "4-default-rack"
+				cfgMapSelector, err := labels.Parse(DefaultConfigMapLabel)
+				Expect(err).To(BeNil())
+				err = mockMgr.appMgr.AddNamespace(NumNSname, cfgMapSelector, 0)
+				Expect(err).To(BeNil())
+
+				cfgFoo := test.NewConfigMap("foomap", "1", NumNSname,
+					map[string]string{
+						"schema": schemaUrl,
+						"data":   configmapFoo,
+					})
+
+				r := mockMgr.addConfigMap(cfgFoo)
+				Expect(r).To(BeTrue(), "Config map should be processed.")
+				resources := mockMgr.resources()
+				rs, ok := resources.Get(serviceKey{"foo", 80, NumNSname},
+					formatConfigMapVSName(cfgFoo))
+				Expect(ok).To(BeTrue(), "Config map should be accessible.")
+				Expect(rs.Virtual.Name).To(Equal("cfgmap_" + NumNSname + "_foomap"))
+			})
+
 			It("watches namespace labels", func() {
 				nsLabel := "watching"
 				err := mockMgr.startLabelMode(nsLabel)

pkg/appmanager/resourceConfig.go

@@ -222,8 +222,16 @@ func (v *Virtual) SetVirtualAddress(bindAddr string, port int32) {
 }
 
 // format the virtual server name for a ConfigMap
+
+// To handle VS name which start with Number,
+// we are prefixing with 'cfgmap_' to avoid errors with bigip.
 func formatConfigMapVSName(cm *v1.ConfigMap) string {
-	return fmt.Sprintf("%s_%s", cm.ObjectMeta.Namespace, cm.ObjectMeta.Name)
+	VSprefix := "cfgmap"
+	if _, err := strconv.Atoi(cm.ObjectMeta.Namespace[0:1]); err == nil {
+		return fmt.Sprintf("%s_%s_%s", VSprefix, cm.ObjectMeta.Namespace, cm.ObjectMeta.Name)
+	} else {
+		return fmt.Sprintf("%s_%s", cm.ObjectMeta.Namespace, cm.ObjectMeta.Name)
+	}
 }
 
 // format the pool name for a ConfigMap