Skip to content

Conversation

@remram44
Copy link

This one introduces a lot of terms, let's expand them once.

Comment on lines 7 to 9
:abbr:`EVPN` stands for Ethernet Virtual Private Network. This is an extension
of BGP that enables the signaling of bridged (L2) and routed (L3) VPNs over a
of BGP that enables the signaling of bridged (L2) and routed (L3) :abbr:`VPNs (Virtual Private Networks)` over a
common network. EVPN is described in :rfc:`7432` and is updated by several
Copy link
Member

@Jafaral Jafaral Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please wrap your lines to alight with the surrounding text?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that will just make for a larger diff though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we can write all FRR code in one line then so that every change is one line change only! ;).

It is ok to have a couple of lines changes. It is more important to have consistent and well formatted code/docs.

Copy link
Author

@remram44 remram44 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line length is not super consistent across the file, I reflowed to 80 columns which seems to be the intention.

@github-actions github-actions bot added size/M and removed size/XS labels Nov 17, 2025
@Jafaral
Copy link
Member

Jafaral commented Nov 21, 2025

Please amend the second commit to the first one. I.e, there should be only one commit here.

This one introduces a lot of terms, let's expand them once.

Signed-off-by: Remi Rampin <[email protected]>
@remram44
Copy link
Author

@Jafaral Ok, done

@github-actions github-actions bot added the rebase PR needs rebase label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants