-
Notifications
You must be signed in to change notification settings - Fork 1.4k
doc: Expand some of the acronyms in EVPN page #20051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
doc/user/evpn.rst
Outdated
| :abbr:`EVPN` stands for Ethernet Virtual Private Network. This is an extension | ||
| of BGP that enables the signaling of bridged (L2) and routed (L3) VPNs over a | ||
| of BGP that enables the signaling of bridged (L2) and routed (L3) :abbr:`VPNs (Virtual Private Networks)` over a | ||
| common network. EVPN is described in :rfc:`7432` and is updated by several |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please wrap your lines to alight with the surrounding text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that will just make for a larger diff though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we can write all FRR code in one line then so that every change is one line change only! ;).
It is ok to have a couple of lines changes. It is more important to have consistent and well formatted code/docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line length is not super consistent across the file, I reflowed to 80 columns which seems to be the intention.
|
Please amend the second commit to the first one. I.e, there should be only one commit here. |
This one introduces a lot of terms, let's expand them once. Signed-off-by: Remi Rampin <[email protected]>
|
@Jafaral Ok, done |
This one introduces a lot of terms, let's expand them once.