Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Commit b441d4f

Browse files
committed
Merge pull request #695 from firebase/update-ng-version
Match Angular 1.3 and above
2 parents 21831d1 + 1e23107 commit b441d4f

File tree

7 files changed

+26
-6
lines changed

7 files changed

+26
-6
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ sudo: false
55
addons:
66
sauce_connect: true
77
before_install:
8+
- export CHROME_BIN=chromium-browser
89
- export DISPLAY=:99.0
910
- sh -e /etc/init.d/xvfb start
1011
install:

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"!LICENSE"
2626
],
2727
"dependencies": {
28-
"angular": "1.3.x || 1.4.x",
28+
"angular": "^1.3.0",
2929
"firebase": "2.x.x"
3030
}
3131
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"package.json"
2828
],
2929
"dependencies": {
30-
"angular": "1.3.x || 1.4.x",
30+
"angular": "^1.3.0",
3131
"firebase": "2.x.x"
3232
},
3333
"devDependencies": {
@@ -47,7 +47,7 @@
4747
"jasmine-core": "^2.2.0",
4848
"jasmine-spec-reporter": "^2.1.0",
4949
"karma": "~0.12.31",
50-
"karma-chrome-launcher": "^0.1.7",
50+
"karma-chrome-launcher": "^0.2.2",
5151
"karma-coverage": "^0.2.7",
5252
"karma-failed-reporter": "0.0.3",
5353
"karma-firefox-launcher": "^0.1.4",

tests/automatic_karma.conf.js

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
module.exports = function(config) {
55
config.set({
66
frameworks: ['jasmine'],
7-
browsers: ['PhantomJS'],
7+
browsers: ['Chrome'],
88
reporters: ['spec', 'failed', 'coverage'],
99
autowatch: false,
1010
singleRun: true,
@@ -40,4 +40,19 @@ module.exports = function(config) {
4040
'unit/**/*.spec.js'
4141
]
4242
});
43+
44+
var configuration = {
45+
customLaunchers: {
46+
Chrome_travis_ci: {
47+
base: 'Chrome',
48+
flags: ['--no-sandbox']
49+
}
50+
},
51+
};
52+
53+
if (process.env.TRAVIS) {
54+
configuration.browsers = ['Chrome_travis_ci'];
55+
}
56+
57+
config.set(configuration);
4358
};

tests/protractor/tictactoe/tictactoe.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<title>AngularFire TicTacToe e2e Test</title>
55

66
<!-- Angular -->
7-
<script src="../../../node_modules/angular/angular.min.js"></script>
7+
<script src="../../../node_modules/angular/angular.js"></script>
88

99
<!-- Firebase -->
1010
<script src="../../../node_modules/firebase/lib/firebase-web.js"></script>

tests/protractor/tictactoe/tictactoe.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var app = angular.module('tictactoe', ['firebase']);
22
app.controller('TicTacToeCtrl', function Chat($scope, $firebaseObject) {
3+
$scope.board = {};
34
// Get a reference to the Firebase
45
var boardRef = new Firebase('https://angularfire.firebaseio-demo.com/tictactoe');
56

tests/protractor/tictactoe/tictactoe.spec.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,13 @@ describe('TicTacToe App', function () {
1515
var flow = protractor.promise.controlFlow();
1616

1717
function waitOne() {
18-
return protractor.promise.delayed(500);
18+
return protractor.promise.delayed(1500);
1919
}
2020

2121
function sleep() {
22+
// flow.execute takes a function and if the
23+
// function returns a promise it waits for it
24+
// to be resolved
2225
flow.execute(waitOne);
2326
}
2427

0 commit comments

Comments
 (0)