Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Commit eaa688e

Browse files
committed
fix($firebaseRef): $firebaseRef vs. firebaseRef
1 parent ca77e25 commit eaa688e

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

src/firebaseAuthService.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
(function() {
22
"use strict";
33

4-
function FirebaseAuthService($firebaseAuth, firebaseRef) {
5-
return $firebaseAuth(firebaseRef.default);
4+
function FirebaseAuthService($firebaseAuth, $firebaseRef) {
5+
return $firebaseAuth($firebaseRef.default);
66
}
7-
FirebaseAuthService.$inject = ['$firebaseAuth', 'firebaseRef'];
7+
FirebaseAuthService.$inject = ['$firebaseAuth', '$firebaseRef'];
88

99
angular.module('firebase')
1010
.factory('$firebaseAuthService', FirebaseAuthService);

src/firebaseRef.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@
4141
}
4242

4343
angular.module('firebase')
44-
.provider('firebaseRef', FirebaseRef);
44+
.provider('$firebaseRef', FirebaseRef);
4545

4646
})();

tests/unit/FirebaseAuthService.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
'use strict';
22
describe('$firebaseAuthService', function () {
3-
var firebaseRefProvider;
3+
var $firebaseRefProvider;
44
var MOCK_URL = 'https://stub.firebaseio-demo.com/'
55

6-
beforeEach(module('firebase', function(_firebaseRefProvider_) {
7-
firebaseRefProvider = _firebaseRefProvider_;
8-
firebaseRefProvider.registerUrl(MOCK_URL);
6+
beforeEach(module('firebase', function(_$firebaseRefProvider_) {
7+
$firebaseRefProvider = _$firebaseRefProvider_;
8+
$firebaseRefProvider.registerUrl(MOCK_URL);
99
}));
1010

1111
describe('<constructor>', function() {
@@ -18,7 +18,7 @@ describe('$firebaseAuthService', function () {
1818
});
1919
});
2020

21-
it('should exist because we called firebaseRefProvider.registerUrl()', inject(function() {
21+
it('should exist because we called $firebaseRefProvider.registerUrl()', inject(function() {
2222
expect($firebaseAuthService).not.toBe(null);
2323
}));
2424

tests/unit/firebaseRef.spec.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,50 @@
11
'use strict';
22
describe('firebaseRef', function () {
33

4-
var firebaseRefProvider;
4+
var $firebaseRefProvider;
55
var MOCK_URL = 'https://stub.firebaseio-demo.com/'
66

7-
beforeEach(module('firebase', function(_firebaseRefProvider_) {
8-
firebaseRefProvider = _firebaseRefProvider_;
7+
beforeEach(module('firebase', function(_$firebaseRefProvider_) {
8+
$firebaseRefProvider = _$firebaseRefProvider_;
99
}));
1010

1111
describe('registerUrl', function() {
1212

1313
it('creates a single reference with a url', inject(function() {
14-
firebaseRefProvider.registerUrl(MOCK_URL);
15-
expect(firebaseRefProvider.$get().default).toBeAFirebaseRef();
14+
$firebaseRefProvider.registerUrl(MOCK_URL);
15+
expect($firebaseRefProvider.$get().default).toBeAFirebaseRef();
1616
}));
1717

1818
it('creates a default reference with a config object', inject(function() {
19-
firebaseRefProvider.registerUrl({
19+
$firebaseRefProvider.registerUrl({
2020
default: MOCK_URL
2121
});
22-
var firebaseRef = firebaseRefProvider.$get();
22+
var firebaseRef = $firebaseRefProvider.$get();
2323
expect(firebaseRef.default).toBeAFirebaseRef();
2424
}));
2525

2626
it('creates multiple references with a config object', inject(function() {
27-
firebaseRefProvider.registerUrl({
27+
$firebaseRefProvider.registerUrl({
2828
default: MOCK_URL,
2929
messages: MOCK_URL + 'messages'
3030
});
31-
var firebaseRef = firebaseRefProvider.$get();
31+
var firebaseRef = $firebaseRefProvider.$get();
3232
expect(firebaseRef.default).toBeAFirebaseRef();
3333
expect(firebaseRef.messages).toBeAFirebaseRef();
3434
}));
3535

3636
it('should throw an error when no url is provided', inject(function () {
3737
function errorWrapper() {
38-
firebaseRefProvider.registerUrl();
39-
firebaseRefProvider.$get();
38+
$firebaseRefProvider.registerUrl();
39+
$firebaseRefProvider.$get();
4040
}
4141
expect(errorWrapper).toThrow();
4242
}));
4343

4444
it('should throw an error when no default url is provided', inject(function() {
4545
function errorWrapper() {
46-
firebaseRefProvider.registerUrl({ messages: MOCK_URL + 'messages' });
47-
firebaseRefProvider.$get();
46+
$firebaseRefProvider.registerUrl({ messages: MOCK_URL + 'messages' });
47+
$firebaseRefProvider.$get();
4848
}
4949
expect(errorWrapper).toThrow();
5050
}));

0 commit comments

Comments
 (0)