Skip to content

snap: Force usage of libsecret everywhere and remove password manager service plug #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

snap: Force usage of libsecret everywhere and remove password manager service plug #2477

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea49cbf
snap: Do not require password-manager-service
3v1n0 Nov 22, 2023
b81b811
snap: Use libsecret storage in all the environments
3v1n0 Nov 22, 2023
10dd8c9
snap: Force using the file secret backend everywhere
3v1n0 Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ parts:

apps:
mailspring:
command: usr/bin/mailspring --no-sandbox
command: usr/bin/mailspring --no-sandbox --password-store=gnome-libsecret
common-id: mailspring
desktop: usr/share/applications/Mailspring.desktop
extensions: [gnome]
Expand All @@ -56,6 +56,9 @@ apps:
TMPDIR: $XDG_RUNTIME_DIR
# Fallback to XWayland if running in a Wayland session.
DISABLE_WAYLAND: 1
# Force using the libsecret local backend in all the cases, even if no
# portal is detected.
SECRET_BACKEND: file
Copy link
Collaborator

@bengotow bengotow Dec 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we may want to ship this separately since it'll require everyone to re-authenticate their accounts again (since we won't read their previously saved passwords from the password manager service)

Is there a way we can verify libsecret is receiving an encryption master key via a portal? I mostly want to be be sure that Chrome doesn't fall through to https://chromium.googlesource.com/chromium/src/+/53.0.2785.100/components/os_crypt/os_crypt_linux.cc#71 and use the password peanuts for everyone!

Copy link
Contributor Author

@3v1n0 3v1n0 Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I can see that... Well, I kept this a draft as we can avoid it for now.

However ea49cbf is safe to add and can likely be moved to another PR if you prefer.

plugs:
- avahi-observe
- browser-support
Expand All @@ -69,7 +72,6 @@ apps:
- network
- network-bind
- network-observe
- password-manager-service
- pulseaudio
- removable-media
- screen-inhibit-control
Expand Down