WIP: use board ID host command if available

JohnAZoidberg · JohnAZoidberg · commit 8634eeeb445e · 2025-11-21T19:00:32.000+08:00
Signed-off-by: Daniel Schaefer &lt;dhs@frame.work&gt;
diff --git a/framework_lib/src/chromium_ec/mod.rs b/framework_lib/src/chromium_ec/mod.rs
@@ -1616,6 +1616,8 @@ impl CrosEc {
     }
 
     fn read_board_id(&self, channel: u8) -> EcResult<Option<u8>> {
+        // TODO: This change the parmeter to BoardIdType and map that to ADC if needed
+        // if ec.cmd_version_supported(command::EcCommands::ReadBoardId, 0) == Ok(true) {
         self.read_board_id_raw(channel, BOARD_VERSION)
     }
     fn read_board_id_npc_db(&self, channel: u8) -> EcResult<Option<u8>> {

Original file line number	Diff line number	Diff line change
`@@ -1616,6 +1616,8 @@ impl CrosEc {`
`1616`	`1616`	`}`
`1617`	`1617`
`1618`	`1618`	`fn read_board_id(&self, channel: u8) -> EcResult<Option<u8>> {`
	`1619`	`+ // TODO: This change the parmeter to BoardIdType and map that to ADC if needed`
	`1620`	`+ // if ec.cmd_version_supported(command::EcCommands::ReadBoardId, 0) == Ok(true) {`
`1619`	`1621`	`self.read_board_id_raw(channel, BOARD_VERSION)`
`1620`	`1622`	`}`
`1621`	`1623`	`fn read_board_id_npc_db(&self, channel: u8) -> EcResult<Option<u8>> {`