🚨 Ruff fixes

Author: je-cook

bluemira/builders/coil_supports.py

@@ -520,9 +520,7 @@ def _make_rib_profile(self, support_face):
 
         rib_wire = make_polygon({"x": x, "y": 0.0, "z": z}, closed=True)
 
-        rib_face = BluemiraFace(rib_wire)
-
-        return rib_face
+        return BluemiraFace(rib_wire)
 
     def _make_ribs(self, width, support_face):
         xz_profile = self._make_rib_profile(support_face)

bluemira/builders/tools.py

@@ -295,14 +295,15 @@ def pattern_revolved_silhouette(
         except ValueError:
             # TODO @CoronelBuendia: Unknown cause of failure in valid FreeCAD
             # geometries... likely related to precision
+            # 3586
             bluemira_warn(
                 "Boolean cutting operation in pattern_revolved_silhouette has failed, "
                 "trying our best by scaling up the problem. If you don't see a "
                 "subsequent warning, all went to plan."
             )
             volume.scale(1000)
-            for gap in gaps:
-                gap.scale(1000)
+            for gap_ in gaps:
+                gap_.scale(1000)
             try:
                 shapes = boolean_cut(volume, gaps)
                 for shape in shapes:

eudemo/eudemo/blanket/builder.py

@@ -208,12 +208,12 @@ def _subdivide_poloidally(
         return fw, bz, manifold
 
     def get_segments(
-        self, silhouette: BluemiraFace, sub_name: str, inboard: bool, color_index: int
+        self, silhouette: BluemiraFace, sub_name: str, *, inboard: bool, color_index: int
     ):
         """
         Create the sub-layer-segments of the blanket from a silhouette of
         a sub-layer.
-        """
+        """  # noqa: DOC201
         if inboard:
             n_seg_per_sector = self.params.n_bb_inboard.value
             name = self.IBS

eudemo/eudemo/ivc/divertor_silhouette.py

@@ -387,10 +387,10 @@ def _make_circular_baffle(
         blanket_join_point:
             The position (in x-z) where the baffle
             joins to the blanket wall
-        target_start_point:
+        target_baffle_join_point:
             The position (in x-z) where the baffle
             is tangent and joins to the target.
-        target_end_point:
+        target_gradient:
             The position (in x-z) where the target
             joins to the dome.
 

eudemo/eudemo/reactor.py

@@ -902,13 +902,12 @@ def save_reactor(reactor, reactor_config, folder_name):
 
         a_string = f"{reactor_config.global_params.A.value:.2f}".replace(".", "_")
         folder_name = f"results_v02/A_{a_string}"
-        import os
-        os.makedirs(folder_name, exist_ok=True) 
+        Path(folder_name).mkdir(exist_ok=True, parents=True)
         filename = f"{folder_name}/run_time.json"
         with open(filename, "w") as f:
             json.dump(run_time_track, f, indent=2)
         save_reactor(reactor, reactor_config, folder_name=folder_name)
 
     except Exception as e:
         bluemira_error(e.with_traceback(e.__traceback__))
-        raise e
+        raise

eudemo/eudemo_tests/blanket/test_blanket.py

@@ -4,8 +4,7 @@
 #
 # SPDX-License-Identifier: LGPL-2.1-or-later
 
-from bluemira.geometry.coordinates import Coordinates
-from eudemo.blanket import Blanket, BlanketBuilder
+from eudemo.blanket import BlanketBuilder
 from eudemo_tests.blanket.tools import make_simple_blanket
 
 
@@ -26,7 +25,6 @@ def make_blanket_component():
         build_config={},
         ib_silhouette=segments.inboard,
         ob_silhouette=segments.outboard,
-        panel_points=panel_points
+        panel_points=panel_points,
     )
     return params, segments, builder.build()
-

eudemo/eudemo_tests/blanket/tools.py

@@ -4,6 +4,7 @@
 #
 # SPDX-License-Identifier: LGPL-2.1-or-later
 import numpy as np
+
 from bluemira.geometry.coordinates import Coordinates
 from bluemira.geometry.face import BluemiraFace
 from bluemira.geometry.tools import make_circle, make_polygon
@@ -48,7 +49,10 @@ def make_simple_blanket() -> tuple[Coordinates, BlanketSegments]:
     inner.set_ccw([0, 1, 0])
     outer = ob_arc_inner.discretise(ndiscr=10)
     outer.set_ccw([0, 1, 0])
-    panel_points = Coordinates({"x": np.concatenate([inner.x, outer.x]), "z": np.concatenate([inner.z, outer.z])})
+    panel_points = Coordinates({
+        "x": np.concatenate([inner.x, outer.x]),
+        "z": np.concatenate([inner.z, outer.z]),
+    })
 
     return panel_points, BlanketSegments(
         inboard=inboard,