Auto-detect grib files with .grb extension. (#1712)

Let binarize accept also the 'threshold' keyword.

Author: joa-quim

src/gdal.jl

@@ -1713,7 +1713,7 @@ end
 		nbd = (find_in_kwargs(kw, [:band])[1] !== nothing) ? kw[:band] : 1
 		bd = getband(dataset, nbd)
 		ds = Gdal.create(Gdal.getdriver("MEMORY"))
-		layer = createlayer(name = "poligonized", dataset=ds, geom=Gdal.wkbPolygon)
+		layer = createlayer(name="polygonized", dataset=ds, geom=Gdal.wkbPolygon)
 		addfielddefn!(layer, "Px", OFTString, nwidth = 32)
 		#isfloat ? GDALPolygonize(bd.ptr, mask, layer.ptr, 0, options, progress, C_NULL) :
 		          #GDALPolygonize( bd.ptr, mask, layer.ptr, 0, options, progress, C_NULL)	

src/gdal_tools.jl

@@ -121,8 +121,8 @@ Its natural use is to digitize masks images.
 - `max_area`: Maximum area in m2 for a polygon to be retained.
 - `simplify`: Apply the Douglas-Peucker line simplification algorithm to the poligons. Provide a tolerence
     in meters. For example: `simplify=0.5`. But be warned that this is a risky option since a too large tolerance
-	can lead to loss of otherwise good polygons. A good rule of thumb is to use the cell size for the tolerance.
-	And in fact that is what we do when using `simplify=:auto`.
+    can lead to loss of otherwise good polygons. A good rule of thumb is to use the cell size for the tolerance.
+    And in fact that is what we do when using `simplify=:auto`.
 - `sort`: If true, will sort polygons by pixel count. Default is the order that GDAL decides internally.
 """
 function polygonize(data::GItype; gdataset=nothing, kwargs...)

src/gmtreadwrite.jl

@@ -456,7 +456,7 @@ function guess_T_from_ext(fname::String; write::Bool=false, text_only::Bool=fals
 	(!write && (ext == "jp2" || ext == "tif" || ext == "tiff") && (!isfile(fname) && !startswith(fname, "/vsi") &&
 		!occursin("https:", fname) && !occursin("http:", fname) && !occursin("ftps:", fname) && !occursin("ftp:", fname))) &&
 		error("File $fname does not exist.")
-	if     (findfirst(isequal(ext), ["grd", "nc", "nc=gd"])  !== nothing)  out = " -Tg";
+	if     (findfirst(isequal(ext), ["grd", "nc", "nc=gd", "grb", "grib2"])  !== nothing)  out = " -Tg";
 	elseif (findfirst(isequal(ext), ["dat", "txt", "csv", "isf"])   !== nothing)  out = " -Td";
 	elseif (findfirst(isequal(ext), ["jpg", "jpeg", "png", "bmp", "webp"]) 	!== nothing)  out = " -Ti";
 	elseif (findfirst(isequal(ext), ["arrow", "arrows", "shp", _kml, "kmz", "json", "feather", "fgb", "geojson", "gmt", "gpkg", "gpx", "gml", "ipc", "parquet", "sqlite"]) !== nothing)  out = " -To";

src/img_funs.jl

@@ -63,17 +63,20 @@ end
 
 # ---------------------------------------------------------------------------------------------------
 """
-    Ibw = binarize(I::GMTimage, threshold::Int=0; band=1, revert=false) -> GMTimage
+    Ibw = binarize(I::GMTimage, threshold::Int=0; band=1, , threshold::Int=0, revert=false) -> GMTimage
 
 Convert an image to a binary image (black-and-white) using a threshold.
 
 ### Args
 - `I::GMTimage`: input image of type UInt8.
-- `threshold::Int`: A number in the range [0 255]. If the default (`nothing`) is maintained,
-  the threshold is computed using the ``isodata`` method.
+- `threshold::Int`: A number in the range [0 255]. If the default (0) is kept and the keyword
+  `threshold` is not used, then the threshold is computed using the ``isodata`` method.
 
 ### Kwargs
 - band: If the `I` image has more than one band, use `band` to specify which one to binarize.
+  By default the first band is used.
+- `threshold`: Alternative keyword argument to the positional `threshold` argument. Meaning, one can either
+  use the `binarize(I, =??)` or `binarize(I, threshold=??)`.
 - `revert`: If `true`, values below the threshold are set to 255, and values above the threshold are set to 0.
 
 ### Return
@@ -88,13 +91,14 @@ grdimage(I, figsize=6)
 grdimage!(Ibw, figsize=6, xshift=6.1, show=true)
 ```
 """
-function binarize(I::GMTimage, threshold::Int=0; band=1, revert=false)::GMTimage
-	thresh = (threshold == 0) ? isodata(I, band=band) : threshold
+function binarize(I::GMTimage, thresh::Int=0; band=1, threshold::Int=0, revert=false)::GMTimage
+	(thresh == 0 && threshold > 0) && (thresh = threshold)
+	_tresh = (thresh == 0) ? isodata(I, band=band) : thresh
 	img = zeros(UInt8, size(I, 1), size(I, 2))
 	if revert
-		t = I.layout[3] == 'B' ? (view(I.image, :, :, band) .< thresh) : (slicecube(I, band).image .< thresh)
+		t = I.layout[3] == 'B' ? (view(I.image, :, :, band) .< _tresh) : (slicecube(I, band).image .< _tresh)
 	else
-		t = I.layout[3] == 'B' ? (view(I.image, :, :, band) .> thresh) : (slicecube(I, band).image .> thresh)
+		t = I.layout[3] == 'B' ? (view(I.image, :, :, band) .> _tresh) : (slicecube(I, band).image .> _tresh)
 	end
 	img[t] .= 255
 	return mat2img(img, I)

src/lepto_funs.jl

@@ -967,7 +967,7 @@ A new `GMTimage` grayscale image `I` with the edge detection, edges are brighter
 ### Example
 
 Let us vectorize the rice grains in the image "rice.png". The result is not perfect because
-the grains in the image's edge are not closed and therefore not filled. And those get poligonized
+the grains in the image's edge are not closed and therefore not filled. And those get polygonized
 twice (in and outside) making the red lines look thicker (but they are not, they are just doubled).
 
 ```julia