Commit a99de4c
fix: keep objectfit as cover for floating video view (#1849)
### 💡 Overview
In this PR,
- we make sure that floating participant view is always cover, because
its always a small view
- we also remove usage of track.getSettings() for local participant as
it was incorrect
### ⏩ Next iteration - TODO
Next, We should wait for dimensions to be valid to render the video
element.
If we wait now, the delay is 2 seconds for rtc stats to appear, this
makes the video component render after an unnecessary delay.
We will next add a native event listener webrtc level to send dimensions
change update. Then add this mechanism.
---------
Co-authored-by: Copilot <[email protected]>1 parent 8eaa6bf commit a99de4c
File tree
3 files changed
+9
-33
lines changed- packages/react-native-sdk/src
- components
- Call/CallContent
- Participant/ParticipantView
- hooks
3 files changed
+9
-33
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| 224 | + | |
224 | 225 | | |
225 | 226 | | |
226 | 227 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| |||
Lines changed: 6 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
| 1 | + | |
5 | 2 | | |
6 | 3 | | |
7 | 4 | | |
| |||
10 | 7 | | |
11 | 8 | | |
12 | 9 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 10 | + | |
17 | 11 | | |
18 | 12 | | |
19 | 13 | | |
20 | 14 | | |
21 | 15 | | |
22 | | - | |
23 | | - | |
| 16 | + | |
24 | 17 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 18 | | |
45 | 19 | | |
46 | | - | |
47 | 20 | | |
48 | 21 | | |
49 | 22 | | |
50 | 23 | | |
51 | | - | |
| 24 | + | |
52 | 25 | | |
53 | 26 | | |
54 | | - | |
| 27 | + | |
| 28 | + | |
55 | 29 | | |
56 | 30 | | |
57 | 31 | | |
| |||
0 commit comments