Skip to content

Commit d4af106

Browse files
committed
chore: remove custom __init__ of SecretGitLabWebUIOutputHandler
1 parent 1b2bd9a commit d4af106

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

ggshield/cmd/secret/scan/prereceive.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def prereceive_cmd(
9494
if os.getenv("GL_PROTOCOL") == "web":
9595
# We are inside GitLab web UI
9696
output_handler = SecretGitLabWebUIOutputHandler(
97-
secret_config=config.user_config.secret
97+
secret_config=config.user_config.secret, verbose=False
9898
)
9999

100100
if get_breakglass_option():

ggshield/verticals/secret/output/secret_gitlab_webui_output_handler.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from typing import Any
2-
31
from pygitguardian.models import PolicyBreak
42

53
from ggshield.core.filter import censor_match
@@ -34,13 +32,6 @@ class SecretGitLabWebUIOutputHandler(SecretOutputHandler):
3432

3533
use_stderr = True
3634

37-
def __init__(self, *args: Any, **kwargs: Any) -> None:
38-
super().__init__(
39-
*args,
40-
**kwargs,
41-
verbose=False,
42-
)
43-
4435
def _process_scan_impl(self, scan: SecretScanCollection) -> str:
4536
results = list(scan.get_all_results())
4637
# If no secrets or no new secrets were found

tests/unit/verticals/secret/output/test_gitlab_webui_output.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ def test_gitlab_web_ui_output_no_secrets(ignore_known_secrets):
4343
secret_config = SecretConfig(
4444
show_secrets=True, ignore_known_secrets=ignore_known_secrets
4545
)
46-
output_handler = SecretGitLabWebUIOutputHandler(secret_config=secret_config)
46+
output_handler = SecretGitLabWebUIOutputHandler(
47+
secret_config=secret_config, verbose=False
48+
)
4749
scan = SecretScanCollection(
4850
id="scan",
4951
type="test",
@@ -103,7 +105,9 @@ def test_gitlab_web_ui_output_ignore_known_secrets(secrets_types, ignore_known_s
103105
secret_config = SecretConfig(
104106
show_secrets=True, ignore_known_secrets=ignore_known_secrets
105107
)
106-
output_handler = SecretGitLabWebUIOutputHandler(secret_config=secret_config)
108+
output_handler = SecretGitLabWebUIOutputHandler(
109+
secret_config=secret_config, verbose=False
110+
)
107111
output = output_handler._process_scan_impl(
108112
SecretScanCollection(
109113
id="outer_scan",

0 commit comments

Comments
 (0)