Ensure all UDFs have description set in their DDL #354 #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajc242
requested changes
Oct 1, 2024
Collaborator
rajc242
left a comment
rajc242
left a comment
There was a problem hiding this comment.
Please check out comment. Please can we give some more meaningful description. Simple message with implementation won't be much helpful to users.
| CREATE OR REPLACE FUNCTION ${self()}(haystack STRING, needle STRING) RETURNS INT64 AS ( | ||
| CREATE OR REPLACE FUNCTION ${self()}(haystack STRING, needle STRING) RETURNS INT64 | ||
| OPTIONS ( | ||
| description="""Implements regexp_instr/2 (haystack, needle).""" |
Collaborator
There was a problem hiding this comment.
Is that possible to provide a little bit meaningful description so anyone can identify basic use case ?
This function aims to find the starting position of the first occurrence of a "needle" string within a "haystack" string.
|
|
||
| CREATE OR REPLACE FUNCTION ${self()}(haystack STRING, needle STRING, start INT64) RETURNS INT64 AS ( | ||
| CREATE OR REPLACE FUNCTION ${self()}(haystack STRING, needle STRING, start INT64) RETURNS INT64 | ||
| OPTIONS ( |
Collaborator
There was a problem hiding this comment.
This function is an extension of **cw_regexp_instr_2.sqlx** adding a start parameter to specify the starting position for searching the needle within the haystack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.