b/433135671 Use non-static classes for nested test fixtures (#736)

Ensure that all tests are executed, both in IntelliJ and in mvn.

Author: jpassing

sources/src/test/java/com/google/solutions/jitaccess/catalog/legacy/TestLegacyPolicy.java

@@ -302,7 +302,7 @@ public void add_whenProjectHasMultipleBindingsForSameRoleWithDifferentConditions
   }
 
   @Nested
-  public static class ProjectPolicy {
+  public class ProjectPolicy {
 
     //---------------------------------------------------------------------------
     // createName.
@@ -316,7 +316,7 @@ public void createName() {
   }
 
   @Nested
-  public static class RolePolicy {
+  public class RolePolicy {
 
     //---------------------------------------------------------------------------
     // createName.

sources/src/test/java/com/google/solutions/jitaccess/catalog/policy/TestPolicyDocument.java

@@ -200,7 +200,7 @@ public void fromString() throws Exception {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class Issue {
+  public class Issue {
     @Test
     public void toString_whenError() {
       var issue = new PolicyDocument.Issue(true, null, PolicyDocument.Issue.Code.FILE_INVALID, "Error!!1");
@@ -219,7 +219,7 @@ public void toString_whenWarning() {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class EnvironmentElement {
+  public class EnvironmentElement {
 
     @Test
     public void toYaml_whenAclIsEmpty() {
@@ -396,7 +396,7 @@ public void toPolicy() {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class SystemElement {
+  public class SystemElement {
     @Test
     public void toYaml_whenAclIsNull() {
       var policy = new SystemPolicy("sys", "System", null, Map.of());
@@ -545,7 +545,7 @@ public void toPolicy() {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class GroupElement {
+  public class GroupElement {
     @Test
     public void toYaml_whenAclIsEmpty() {
       var policy = new JitGroupPolicy(
@@ -627,7 +627,7 @@ public void toYaml_whenGkeEnabled() {
         AccessControlList.EMPTY,
         Map.of(),
         List.of(),
-        false);
+        true);
       var element = PolicyDocument.GroupElement.toYaml(policy);
 
       assertEquals("group", element.name());
@@ -675,7 +675,6 @@ public void toPolicy_whenAclInvalid() {
       assertEquals(
         PolicyDocument.Issue.Code.ACL_INVALID_PRINCIPAL,
         issues.issues().get(0).code());
-      assertFalse(policy.get().isGkeEnabled());
     }
 
     @Test
@@ -697,7 +696,6 @@ public void toPolicy_whenConstraintInvalid() {
       assertEquals(
         PolicyDocument.Issue.Code.CONSTRAINT_INVALID_TYPE,
         issues.issues().get(0).code());
-      assertFalse(policy.get().isGkeEnabled());
     }
 
     @Test
@@ -721,7 +719,6 @@ public void toPolicy_whenJoinConstraintsContainMultipleExpiryConstraints() {
       assertEquals(
         PolicyDocument.Issue.Code.CONSTRAINT_INVALID_EXPIRY,
         issues.issues().get(0).code());
-      assertFalse(policy.get().isGkeEnabled());
     }
 
     @Test
@@ -742,7 +739,6 @@ public void toPolicy_whenApprovalConstraintsContainExpiryConstraint() {
       assertEquals(
         PolicyDocument.Issue.Code.CONSTRAINT_INVALID_EXPIRY,
         issues.issues().get(0).code());
-      assertFalse(policy.get().isGkeEnabled());
     }
 
     @Test
@@ -763,7 +759,6 @@ public void toPolicy_whenBindingInvalid() {
       assertEquals(
         PolicyDocument.Issue.Code.PRIVILEGE_INVALID_RESOURCE_ID,
         issues.issues().get(0).code());
-      assertFalse(policy.get().isGkeEnabled());
     }
 
     @Test
@@ -793,7 +788,7 @@ public void toPolicy() {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class AccessControlEntryElement {
+  public class AccessControlEntryElement {
     @Test
     public void toYaml_whenAllowMaskCombinesMultipleValues() {
       var ace = new AccessControlList.AllowedEntry(SAMPLE_USER, 15);
@@ -898,7 +893,7 @@ public void toPolicy(String principalId) {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class ConstraintElement {
+  public class ConstraintElement {
     @Test
     public void toYaml_whenFixedExpiry() {
       var constraint = new ExpiryConstraint(Duration.ofMinutes(5));
@@ -1106,7 +1101,7 @@ public void toPolicy_whenExpressionHasNoVariables() {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class CelVariableElement {
+  public class CelVariableElement {
     @Test
     public void toYaml_whenTypeInvalid() {
       var variable = new CelConstraint.Variable("test", "test") {
@@ -1239,7 +1234,7 @@ public void toPolicy_whenBoolean(String type) {
   //---------------------------------------------------------------------------
 
   @Nested
-  public static class IamRoleBindingElement {
+  public class IamRoleBindingElement {
     @Test
     public void toYaml_whenTypeInvalid() {
       var binding = new IamRoleBinding(

sources/src/test/java/com/google/solutions/jitaccess/web/proposal/TestMailProposalHandler.java

@@ -133,7 +133,7 @@ public void onProposalApproved() throws Exception {
   }
 
   @Nested
-  public static class MailTemplate {
+  public class MailTemplate {
 
     //-------------------------------------------------------------------------
     // fromResource.

sources/src/test/java/com/google/solutions/jitaccess/web/rest/TestEnvironmentsResource.java

@@ -401,7 +401,7 @@ public void reconcile_whenPermissionsInsufficient() {
   }
 
   @Nested
-  public static class EnvironmentInfo {
+  public class EnvironmentInfo {
     @Test
     public void create_whenExportAndReconcileNotAllowed() {
       var environment = new EnvironmentPolicy(